[GitHub] [incubator-nuttx] fjpanag commented on pull request #4028: syslog: fix log confusion when multi task writing together

[GitBox <gi...@apache.org>]

fjpanag commented on pull request #4028:
URL: https://github.com/apache/incubator-nuttx/pull/4028#issuecomment-872953736


   Hi @Donny9 
   
   I had a look at the changes, but I don't think that this will fix the issue.  
   The problem is not the thread safety of the drivers, rather the multiple calls to `lib_sprintf()`.  
   See #3599.
   
   Adding a `sc_write()` to all channels seems a good way forward.
   If `syslog_write_t` is modified to also accept a `force` flag, we can eliminate the `syslog_putc_t` too.
   
   But I think a semaphore at this place will not solve the actual issue. Depending on the solution to the initial problem, it may not be needed at all.
   
   Do you have any plans for further development on this?  
   (I have also spent quite some time thinking about this and experimenting, but I haven't reached a "good" final implementation...)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org