You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2015/01/30 15:22:36 UTC
Review Request 30451: Hive configs versions without difference are
created after operations with HiveServer2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30451/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
Bugs: AMBARI-9414
https://issues.apache.org/jira/browse/AMBARI-9414
Repository: ambari
Description
-------
After adding, deleting or moving HiveServer2 new Hive configs version is created, but it contains no difference with the previous one.
The same occurs for core-site configs.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java e867f99
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java e2ae6d6
Diff: https://reviews.apache.org/r/30451/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 30451: Hive configs versions without difference are
created after operations with HiveServer2
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
> On Січ. 30, 2015, 3:24 після полудня, Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java, lines 1232-1257
> > <https://reviews.apache.org/r/30451/diff/1/?file=841753#file841753line1232>
> >
> > I actually don't see a problem with creating a new configuration when hive server is moved, but apparently someone did since the bug was filed.
> >
> > With that said, comparing configurations for equality between a request and an existing configuration type is something that could probably go in ConfigHelper to be reused in other areas of the application. Can we move this to a central location?
I aggree with you that it will be better to move this in some central place. But as of now, i'm going to work with stack upgrade testing and i don't have a time to do this changes and fix tests for this. If you agree i can create new ticket for this?
- Vitalyi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30451/#review70364
-----------------------------------------------------------
On Січ. 30, 2015, 2:22 після полудня, Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30451/
> -----------------------------------------------------------
>
> (Updated Січ. 30, 2015, 2:22 після полудня)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-9414
> https://issues.apache.org/jira/browse/AMBARI-9414
>
>
> Repository: ambari
>
>
> Description
> -------
>
> After adding, deleting or moving HiveServer2 new Hive configs version is created, but it contains no difference with the previous one.
> The same occurs for core-site configs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java e867f99
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java e2ae6d6
>
> Diff: https://reviews.apache.org/r/30451/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 30451: Hive configs versions without difference are
created after operations with HiveServer2
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Jan. 30, 2015, 10:24 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java, lines 1232-1257
> > <https://reviews.apache.org/r/30451/diff/1/?file=841753#file841753line1232>
> >
> > I actually don't see a problem with creating a new configuration when hive server is moved, but apparently someone did since the bug was filed.
> >
> > With that said, comparing configurations for equality between a request and an existing configuration type is something that could probably go in ConfigHelper to be reused in other areas of the application. Can we move this to a central location?
>
> Vitalyi Brodetskyi wrote:
> I aggree with you that it will be better to move this in some central place. But as of now, i'm going to work with stack upgrade testing and i don't have a time to do this changes and fix tests for this. If you agree i can create new ticket for this?
As long as a ticket exists, I'm OK with it since there's no problem with the code. Moving it to a central location would take only a few minutes though.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30451/#review70364
-----------------------------------------------------------
On Feb. 2, 2015, 10:55 a.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30451/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2015, 10:55 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-9414
> https://issues.apache.org/jira/browse/AMBARI-9414
>
>
> Repository: ambari
>
>
> Description
> -------
>
> After adding, deleting or moving HiveServer2 new Hive configs version is created, but it contains no difference with the previous one.
> The same occurs for core-site configs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java e867f99
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java e2ae6d6
>
> Diff: https://reviews.apache.org/r/30451/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 30451: Hive configs versions without difference are
created after operations with HiveServer2
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30451/#review70364
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
<https://reviews.apache.org/r/30451/#comment115479>
I actually don't see a problem with creating a new configuration when hive server is moved, but apparently someone did since the bug was filed.
With that said, comparing configurations for equality between a request and an existing configuration type is something that could probably go in ConfigHelper to be reused in other areas of the application. Can we move this to a central location?
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
<https://reviews.apache.org/r/30451/#comment115478>
You can short circuit the loop at this point by just checking to see if requestConfigProperties is null; no reason to do any extra work like getting the clusterConfig if there's nothing in the request.
- Jonathan Hurley
On Jan. 30, 2015, 9:22 a.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30451/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2015, 9:22 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-9414
> https://issues.apache.org/jira/browse/AMBARI-9414
>
>
> Repository: ambari
>
>
> Description
> -------
>
> After adding, deleting or moving HiveServer2 new Hive configs version is created, but it contains no difference with the previous one.
> The same occurs for core-site configs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java e867f99
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java e2ae6d6
>
> Diff: https://reviews.apache.org/r/30451/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 30451: Hive configs versions without difference are
created after operations with HiveServer2
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30451/#review70360
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 30, 2015, 2:22 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30451/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2015, 2:22 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-9414
> https://issues.apache.org/jira/browse/AMBARI-9414
>
>
> Repository: ambari
>
>
> Description
> -------
>
> After adding, deleting or moving HiveServer2 new Hive configs version is created, but it contains no difference with the previous one.
> The same occurs for core-site configs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java e867f99
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java e2ae6d6
>
> Diff: https://reviews.apache.org/r/30451/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>