You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Knut Anders Hatlen (JIRA)" <de...@db.apache.org> on 2006/07/25 13:33:13 UTC
[jira] Created: (DERBY-1586) The attributesAsPassword property
doesn't work correctly with EmbeddedConnectionPoolDataSource
The attributesAsPassword property doesn't work correctly with EmbeddedConnectionPoolDataSource
----------------------------------------------------------------------------------------------
Key: DERBY-1586
URL: http://issues.apache.org/jira/browse/DERBY-1586
Project: Derby
Issue Type: Bug
Components: JDBC
Affects Versions: 10.2.0.0
Reporter: Knut Anders Hatlen
Assigned To: Knut Anders Hatlen
Priority: Minor
When attributesAsPassword is true, EmbeddedConnectionPoolDataSource.getPooledConnection() appends the default password to the connection url. This leads to a malformed url error if the password is not on the form "xxx=yyy". If the password is on the form "xxx=yyy", it might cause other unexpected consequences (for instance if it is "shutdown=true"). This is not a problem with EmbeddedDataSource or EmbeddedXADataSource. In Derby 10.1.3.1, it works as expected, so this is a regression.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1586) The attributesAsPassword property
doesn't work correctly with EmbeddedConnectionPoolDataSource
Posted by "Knut Anders Hatlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1586?page=all ]
Knut Anders Hatlen updated DERBY-1586:
--------------------------------------
Derby Info: [Patch Available, Regression] (was: [Regression])
> The attributesAsPassword property doesn't work correctly with EmbeddedConnectionPoolDataSource
> ----------------------------------------------------------------------------------------------
>
> Key: DERBY-1586
> URL: http://issues.apache.org/jira/browse/DERBY-1586
> Project: Derby
> Issue Type: Bug
> Components: JDBC
> Affects Versions: 10.2.0.0
> Reporter: Knut Anders Hatlen
> Assigned To: Knut Anders Hatlen
> Priority: Minor
> Attachments: 1586-test.diff, 1586-v1.diff, 1586-v1.stat
>
>
> When attributesAsPassword is true, EmbeddedConnectionPoolDataSource.getPooledConnection() appends the default password to the connection url. This leads to a malformed url error if the password is not on the form "xxx=yyy". If the password is on the form "xxx=yyy", it might cause other unexpected consequences (for instance if it is "shutdown=true"). This is not a problem with EmbeddedDataSource or EmbeddedXADataSource. In Derby 10.1.3.1, it works as expected, so this is a regression.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1586) The attributesAsPassword property
doesn't work correctly with EmbeddedConnectionPoolDataSource
Posted by "Knut Anders Hatlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1586?page=all ]
Knut Anders Hatlen updated DERBY-1586:
--------------------------------------
Attachment: 1586-test.diff
1586-test.diff adds a new JUnit test, jdbcapi/DataSourcePropertiesTest.junit, which reproduces the bug. It fails with this error:
*** Start: DataSourcePropertiesTest jdk1.5.0_04 2006-07-25 13:36:12 ***
0 add
> ..E....
> There was 1 error:
> 1) embeddedTestAttributesAsPasswordWithoutPassword_pooled(org.apache.derbyTesting.functionTests.tests.jdbcapi.DataSourcePropertiesTest)java.sql.SQLException: The URL 'jdbc:derby:wombat;create=true;mypassword' is not properly formed.
> FAILURES!!!
> Tests run: 6, Failures: 0, Errors: 1
Test Failed.
*** End: DataSourcePropertiesTest jdk1.5.0_04 2006-07-25 13:36:15 ***
The test runs cleanly against derby.jar from 10.1.3.1.
> The attributesAsPassword property doesn't work correctly with EmbeddedConnectionPoolDataSource
> ----------------------------------------------------------------------------------------------
>
> Key: DERBY-1586
> URL: http://issues.apache.org/jira/browse/DERBY-1586
> Project: Derby
> Issue Type: Bug
> Components: JDBC
> Affects Versions: 10.2.0.0
> Reporter: Knut Anders Hatlen
> Assigned To: Knut Anders Hatlen
> Priority: Minor
> Attachments: 1586-test.diff
>
>
> When attributesAsPassword is true, EmbeddedConnectionPoolDataSource.getPooledConnection() appends the default password to the connection url. This leads to a malformed url error if the password is not on the form "xxx=yyy". If the password is on the form "xxx=yyy", it might cause other unexpected consequences (for instance if it is "shutdown=true"). This is not a problem with EmbeddedDataSource or EmbeddedXADataSource. In Derby 10.1.3.1, it works as expected, so this is a regression.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1586) The attributesAsPassword property
doesn't work correctly with EmbeddedConnectionPoolDataSource
Posted by "Knut Anders Hatlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1586?page=comments#action_12423317 ]
Knut Anders Hatlen commented on DERBY-1586:
-------------------------------------------
1586-test.diff committed into trunk with revision 425385. The new test is not enabled in any suite yet.
> The attributesAsPassword property doesn't work correctly with EmbeddedConnectionPoolDataSource
> ----------------------------------------------------------------------------------------------
>
> Key: DERBY-1586
> URL: http://issues.apache.org/jira/browse/DERBY-1586
> Project: Derby
> Issue Type: Bug
> Components: JDBC
> Affects Versions: 10.2.0.0
> Reporter: Knut Anders Hatlen
> Assigned To: Knut Anders Hatlen
> Priority: Minor
> Attachments: 1586-test.diff
>
>
> When attributesAsPassword is true, EmbeddedConnectionPoolDataSource.getPooledConnection() appends the default password to the connection url. This leads to a malformed url error if the password is not on the form "xxx=yyy". If the password is on the form "xxx=yyy", it might cause other unexpected consequences (for instance if it is "shutdown=true"). This is not a problem with EmbeddedDataSource or EmbeddedXADataSource. In Derby 10.1.3.1, it works as expected, so this is a regression.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1586) The attributesAsPassword property
doesn't work correctly with EmbeddedConnectionPoolDataSource
Posted by "Knut Anders Hatlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1586?page=all ]
Knut Anders Hatlen updated DERBY-1586:
--------------------------------------
Attachment: 1586-v1.diff
1586-v1.stat
Attached '1586-v1.diff' to address the problem. EmbeddedConnectionPoolDataSource.createPooledConnection() took a requestPassword parameter that it didn't pass along to the EmbedPooledConnection it created. The same bug was also present in EmbeddedConnectionPoolDataSource40. It was fixed by forwarding the parameter to the constructor of EmbedPooledConnection.
The patch enables DataSourcePropertiesTest in all frameworks (but not for jdk1.3/j2me because it accesses XADataSource). Derbyall runs cleanly. Reviews would be appreciated. Thanks!
> The attributesAsPassword property doesn't work correctly with EmbeddedConnectionPoolDataSource
> ----------------------------------------------------------------------------------------------
>
> Key: DERBY-1586
> URL: http://issues.apache.org/jira/browse/DERBY-1586
> Project: Derby
> Issue Type: Bug
> Components: JDBC
> Affects Versions: 10.2.0.0
> Reporter: Knut Anders Hatlen
> Assigned To: Knut Anders Hatlen
> Priority: Minor
> Attachments: 1586-test.diff, 1586-v1.diff, 1586-v1.stat
>
>
> When attributesAsPassword is true, EmbeddedConnectionPoolDataSource.getPooledConnection() appends the default password to the connection url. This leads to a malformed url error if the password is not on the form "xxx=yyy". If the password is on the form "xxx=yyy", it might cause other unexpected consequences (for instance if it is "shutdown=true"). This is not a problem with EmbeddedDataSource or EmbeddedXADataSource. In Derby 10.1.3.1, it works as expected, so this is a regression.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (DERBY-1586) The attributesAsPassword property
doesn't work correctly with EmbeddedConnectionPoolDataSource
Posted by "Knut Anders Hatlen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1586?page=all ]
Knut Anders Hatlen closed DERBY-1586.
-------------------------------------
Fix Version/s: 10.2.0.0
Resolution: Fixed
Derby Info: [Regression] (was: [Patch Available, Regression])
Committed revision 426398.
> The attributesAsPassword property doesn't work correctly with EmbeddedConnectionPoolDataSource
> ----------------------------------------------------------------------------------------------
>
> Key: DERBY-1586
> URL: http://issues.apache.org/jira/browse/DERBY-1586
> Project: Derby
> Issue Type: Bug
> Components: JDBC
> Affects Versions: 10.2.0.0
> Reporter: Knut Anders Hatlen
> Assigned To: Knut Anders Hatlen
> Priority: Minor
> Fix For: 10.2.0.0
>
> Attachments: 1586-test.diff, 1586-v1.diff, 1586-v1.stat
>
>
> When attributesAsPassword is true, EmbeddedConnectionPoolDataSource.getPooledConnection() appends the default password to the connection url. This leads to a malformed url error if the password is not on the form "xxx=yyy". If the password is on the form "xxx=yyy", it might cause other unexpected consequences (for instance if it is "shutdown=true"). This is not a problem with EmbeddedDataSource or EmbeddedXADataSource. In Derby 10.1.3.1, it works as expected, so this is a regression.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira