You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Ivan Stojic (JIRA)" <ji...@apache.org> on 2008/05/22 14:10:54 UTC
[jira] Created: (SMX4KNL-44) Changed bundles restarted twice
Changed bundles restarted twice
-------------------------------
Key: SMX4KNL-44
URL: https://issues.apache.org/activemq/browse/SMX4KNL-44
Project: ServiceMix Kernel
Issue Type: Bug
Affects Versions: 1.0-m3
Reporter: Ivan Stojic
When a bundle file is replaced or 'touch'-ed in the deploy directory, the bundle is being restarted twice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SMX4KNL-44) Changed bundles restarted twice
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMX4KNL-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet updated SMX4KNL-44:
-----------------------------------
Fix Version/s: 1.0-rc1
(was: 1.0-rc2)
> Changed bundles restarted twice
> -------------------------------
>
> Key: SMX4KNL-44
> URL: https://issues.apache.org/activemq/browse/SMX4KNL-44
> Project: ServiceMix Kernel
> Issue Type: Bug
> Affects Versions: 1.0-m3
> Reporter: Ivan Stojic
> Assignee: Guillaume Nodet
> Fix For: 1.0-rc1
>
>
> When a bundle file is replaced or 'touch'-ed in the deploy directory, the bundle is being restarted twice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SMX4KNL-44) Changed bundles restarted twice
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMX4KNL-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet resolved SMX4KNL-44.
------------------------------------
Fix Version/s: 1.0-rc1
(was: 1.0-m3)
Resolution: Fixed
Now solved correctly
> Changed bundles restarted twice
> -------------------------------
>
> Key: SMX4KNL-44
> URL: https://issues.apache.org/activemq/browse/SMX4KNL-44
> Project: ServiceMix Kernel
> Issue Type: Bug
> Affects Versions: 1.0-m3
> Reporter: Ivan Stojic
> Assignee: Gert Vanthienen
> Fix For: 1.0-rc1
>
>
> When a bundle file is replaced or 'touch'-ed in the deploy directory, the bundle is being restarted twice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SMX4KNL-44) Changed bundles restarted twice
Posted by "Gert Vanthienen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMX4KNL-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gert Vanthienen resolved SMX4KNL-44.
------------------------------------
Fix Version/s: 1.0-m3
Resolution: Fixed
Fixed in http://svn.apache.org/viewvc?view=rev&revision=659512
> Changed bundles restarted twice
> -------------------------------
>
> Key: SMX4KNL-44
> URL: https://issues.apache.org/activemq/browse/SMX4KNL-44
> Project: ServiceMix Kernel
> Issue Type: Bug
> Affects Versions: 1.0-m3
> Reporter: Ivan Stojic
> Fix For: 1.0-m3
>
>
> When a bundle file is replaced or 'touch'-ed in the deploy directory, the bundle is being restarted twice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SMX4KNL-44) Changed bundles restarted twice
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMX4KNL-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43169#action_43169 ]
Guillaume Nodet commented on SMX4KNL-44:
----------------------------------------
Digging into this issue a bit more, i think the refreshPackages(bundleChanged) has to be called, and called after starting / updating the other bundles.
Unfortunately, when doing so, we hit a problem with Spring-DM: Spring-DM 1.0.x uses Dynamic-Import, and refreshing a spring app leads to spring-extender being refreshed, therefore all the spring DM applications are refreshed too. It seems this problem will be solved when switching to Spring DM 1.1 + Spring 2.5.4.
However, I'm not sure that it will fix the original bug, which is that the updated bundle is restarted twice (further investigation is needed).
> Changed bundles restarted twice
> -------------------------------
>
> Key: SMX4KNL-44
> URL: https://issues.apache.org/activemq/browse/SMX4KNL-44
> Project: ServiceMix Kernel
> Issue Type: Bug
> Affects Versions: 1.0-m3
> Reporter: Ivan Stojic
> Fix For: 1.0-rc1
>
>
> When a bundle file is replaced or 'touch'-ed in the deploy directory, the bundle is being restarted twice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SMX4KNL-44) Changed bundles restarted twice
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMX4KNL-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet resolved SMX4KNL-44.
------------------------------------
Assignee: Guillaume Nodet
Fix Version/s: 1.0-rc2
(was: 1.0-rc1)
Resolution: Fixed
I think the only way to fix the original problem is to have an explicit call to refreshPackages through a command, but I doubt it is a good solution, as imho, users expect the updated bundle to be used immediately.
So with the fix at revision 662445, when a bundle in the deploy dir is 'touch'ed, the following happens:
* the bundle is updated, which means it is stopped, updated, resolved and start again
* if the bundle is in use (some packages are imported by other bundles), a graph of dependent bundles is computed by the framework and they are all stopped / resolved / started again
This means that for a "library" which only contains code, the bundle will be restarted twice, once for the update and another one with all the dependant bundles. For an "application" where packages are not imported by other bundles, the bundle will be restarted only once.
I've tried to make that better, but the refreshPackages is handled asynchronously by the framework, which means there is no simple way to stop bundle, call refreshPackages() and restart the bundle later.
http://svn.apache.org/viewvc?rev=662445&view=rev
> Changed bundles restarted twice
> -------------------------------
>
> Key: SMX4KNL-44
> URL: https://issues.apache.org/activemq/browse/SMX4KNL-44
> Project: ServiceMix Kernel
> Issue Type: Bug
> Affects Versions: 1.0-m3
> Reporter: Ivan Stojic
> Assignee: Guillaume Nodet
> Fix For: 1.0-rc2
>
>
> When a bundle file is replaced or 'touch'-ed in the deploy directory, the bundle is being restarted twice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SMX4KNL-44) Changed bundles restarted twice
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMX4KNL-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43170#action_43170 ]
Guillaume Nodet commented on SMX4KNL-44:
----------------------------------------
See http://groups.google.com/group/spring-osgi/browse_thread/thread/793d9700488a78ba for the thread about the above comment.
> Changed bundles restarted twice
> -------------------------------
>
> Key: SMX4KNL-44
> URL: https://issues.apache.org/activemq/browse/SMX4KNL-44
> Project: ServiceMix Kernel
> Issue Type: Bug
> Affects Versions: 1.0-m3
> Reporter: Ivan Stojic
> Fix For: 1.0-rc1
>
>
> When a bundle file is replaced or 'touch'-ed in the deploy directory, the bundle is being restarted twice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SMX4KNL-44) Changed bundles restarted twice
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMX4KNL-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet reopened SMX4KNL-44:
------------------------------------
Assignee: (was: Gert Vanthienen)
I think the fix has a problem in that if not calling the refreshPackages() method, the new bundle is not really used. So for bundles that are not consumed by other bundles, the fix works fine, as the bundle is only restarted once. However, when the bundle is consumed by another bundle by importing some packages, which is a usual case when you deploy a library, the new version does not seem to be used by other bundles and in such case, the only way is to restart the framework :-(
> Changed bundles restarted twice
> -------------------------------
>
> Key: SMX4KNL-44
> URL: https://issues.apache.org/activemq/browse/SMX4KNL-44
> Project: ServiceMix Kernel
> Issue Type: Bug
> Affects Versions: 1.0-m3
> Reporter: Ivan Stojic
> Fix For: 1.0-rc1
>
>
> When a bundle file is replaced or 'touch'-ed in the deploy directory, the bundle is being restarted twice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SMX4KNL-44) Changed bundles restarted twice
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SMX4KNL-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet reopened SMX4KNL-44:
------------------------------------
Assignee: Gert Vanthienen
Looks like the right thing to do is rather to remove the call to refreshPackages instead of update()
> Changed bundles restarted twice
> -------------------------------
>
> Key: SMX4KNL-44
> URL: https://issues.apache.org/activemq/browse/SMX4KNL-44
> Project: ServiceMix Kernel
> Issue Type: Bug
> Affects Versions: 1.0-m3
> Reporter: Ivan Stojic
> Assignee: Gert Vanthienen
> Fix For: 1.0-m3
>
>
> When a bundle file is replaced or 'touch'-ed in the deploy directory, the bundle is being restarted twice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.