You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@xalan.apache.org by GitBox <gi...@apache.org> on 2021/05/05 09:33:11 UTC
[GitHub] [xalan-c] Biswa96 opened a new pull request #36: Fix building in MinGW
Biswa96 opened a new pull request #36:
URL: https://github.com/apache/xalan-c/pull/36
Changes:
* Check XALAN_WINDOWS instead of _MSC_VER for Win32 platform.
* Check _MSC_VER for MSVC specific pragma directives.
* Check Win32 platform for std::FILE type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For additional commands, e-mail: dev-help@xalan.apache.org
[GitHub] [xalan-c] rleigh-codelibre merged pull request #36: Fix building in MinGW
Posted by GitBox <gi...@apache.org>.
rleigh-codelibre merged pull request #36:
URL: https://github.com/apache/xalan-c/pull/36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For additional commands, e-mail: dev-help@xalan.apache.org
[GitHub] [xalan-c] Biswa96 commented on a change in pull request #36: Fix building in MinGW
Posted by GitBox <gi...@apache.org>.
Biswa96 commented on a change in pull request #36:
URL: https://github.com/apache/xalan-c/pull/36#discussion_r626880552
##########
File path: src/xalanc/PlatformSupport/XalanFileOutputStream.hpp
##########
@@ -40,8 +40,9 @@
namespace XALAN_CPP_NAMESPACE {
-
+#if !defined(XALAN_WINDOWS)
Review comment:
The Windows one seems to be using HANDLE (i.e. void*) type instead of FILE type. Also with mingw clang this happens error: no member named 'FILE' in namespace 'std'; did you mean '::FILE'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For additional commands, e-mail: dev-help@xalan.apache.org
[GitHub] [xalan-c] rleigh-codelibre commented on a change in pull request #36: Fix building in MinGW
Posted by GitBox <gi...@apache.org>.
rleigh-codelibre commented on a change in pull request #36:
URL: https://github.com/apache/xalan-c/pull/36#discussion_r626871990
##########
File path: src/xalanc/PlatformSupport/XalanFileOutputStream.hpp
##########
@@ -40,8 +40,9 @@
namespace XALAN_CPP_NAMESPACE {
-
+#if !defined(XALAN_WINDOWS)
Review comment:
Why is this inappropriate for Windows?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xalan.apache.org
For additional commands, e-mail: dev-help@xalan.apache.org