[GitHub] [storm] Ethanlm commented on a change in pull request #3050: STORM-3434: server: fix all checkstyle warnings

[GitBox <gi...@apache.org>]

Ethanlm commented on a change in pull request #3050: STORM-3434: server: fix all checkstyle warnings
URL: https://github.com/apache/storm/pull/3050#discussion_r316739783
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/scheduler/multitenant/NodePool.java
 ##########
 @@ -46,6 +46,12 @@ public static int slotsAvailable(NodePool[] pools) {
         return slotsAvailable;
     }
 
+    /**
+     * Get number of available slots.
+     * @return the number of nodes that are available to be taken
 
 Review comment:
   This is `the number of slots` not `nodes`. But I am fine with it since you are just moving things around.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services