You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Chris M. Hostetter (Jira)" <ji...@apache.org> on 2021/03/19 17:19:00 UTC

[jira] [Resolved] (SOLR-15265) decide if/how to validate lucene javadoc links

     [ https://issues.apache.org/jira/browse/SOLR-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris M. Hostetter resolved SOLR-15265.
---------------------------------------
    Fix Version/s: main (9.0)
       Resolution: Fixed

{quote}Ref guide build should really depend on those javadocs it links to - then there would be no awkwardness and, ideally, you could just sync the resources you need into the final structure (that's why I declared javadocs as an artifact).
{quote}
Hmmm... I'm not really sure I'm following you there (we already have {{checkLocalJavadocLinksSite.dependsOn ':documentation'}} to depend on all artifacts) and while we could sync/duplicate the javadocs in the ref-guide/build the "awkwardness" of that line would still exist: because regardless of what directory they are in,  we need to construct the "link prefix" (using '/' regardless of filesystem) that asciidoctor expects.

that said ... I get the impression that you are making a distinction that I don't have a frame of reference to understand because i don't grok gradle dependencies enough (like i live in flatland you are a 3D cube) so I made sure to include your note as a TODO comment with a ref back to this Jira for the full discussion.

> decide if/how to validate lucene javadoc links
> ----------------------------------------------
>
>                 Key: SOLR-15265
>                 URL: https://issues.apache.org/jira/browse/SOLR-15265
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Chris M. Hostetter
>            Assignee: Chris M. Hostetter
>            Priority: Major
>             Fix For: main (9.0)
>
>         Attachments: SOLR-15265.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> From parent issue...
> {quote}
> come up with a longer term plan for if/how we want to "validate" links to lucene javadocs
> * we currently don't do any validation of links to "remote" urls in the ref-guide content – regardless of wether they are hardcoded or version specific via ivy properties
> * we may want to revisit that now ... either in general, or via some lucene specific logic (possibly via fetching lucene src or javadoc jars) since we have so many links to lucene class javadocs
> {quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)