You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "ldube (via GitHub)" <gi...@apache.org> on 2024/08/02 02:29:16 UTC

[PR] arm: Make ARMv5 boards work again [nuttx]

ldube opened a new pull request, #12825:
URL: https://github.com/apache/nuttx/pull/12825

   ## Summary
   Fix some bugs found while trying run modern NuttX on an old board.
   
   ## Impact
   
   ## Testing
   NuttX builds and runs on my board but most of the board support is not in the repo.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arm: Make ARMv5 boards work again [nuttx]

Posted by "ldube (via GitHub)" <gi...@apache.org>.
ldube commented on PR #12825:
URL: https://github.com/apache/nuttx/pull/12825#issuecomment-2264394463

   @acassis Please check if this fixes #8966.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arm: Make ARMv5 boards work again [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #12825:
URL: https://github.com/apache/nuttx/pull/12825


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arm: Make ARMv5 boards work again [nuttx]

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #12825:
URL: https://github.com/apache/nuttx/pull/12825#issuecomment-2267184126

   What board did you use?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arm: Make ARMv5 boards work again [nuttx]

Posted by "ldube (via GitHub)" <gi...@apache.org>.
ldube commented on PR #12825:
URL: https://github.com/apache/nuttx/pull/12825#issuecomment-2267244953

   I think arm_decodeirq needs to be updated. The return value is important. If nothing changes, you return the argument instead of NULL. I do not call irq_dispatch directly. That is done by arm_doirq.
   Here is my arm_decodeirq:
   
   uint32_t *arm_decodeirq(uint32_t *regs)
   {
   #ifdef CONFIG_SUPPRESS_INTERRUPTS
     err("ERROR: Unexpected IRQ\n");
     PANIC();
   #else
   
     unsigned int irq_enc = ic_getreg32(INTR_IRQ_ENC_ST_OFFSET) >> 2;
     if (irq_enc != 0)
       {
         unsigned int irq = irq_enc - 1;
         /* Verify that the resulting IRQ number is valid */
         if (irq < NR_IRQS)
           {
             /* Deliver the IRQ */
             regs = arm_doirq(irq, regs);
           }
       }
   #endif
     return regs;
   }
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arm: Make ARMv5 boards work again [nuttx]

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #12825:
URL: https://github.com/apache/nuttx/pull/12825#issuecomment-2267511753

   Hi @ldube thank you very much!
   That NSLU2 device is really nice. If you can, please submit the board support to mainline. I'll buy one from eBay.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arm: Make ARMv5 boards work again [nuttx]

Posted by "ldube (via GitHub)" <gi...@apache.org>.
ldube commented on PR #12825:
URL: https://github.com/apache/nuttx/pull/12825#issuecomment-2267228415

   https://en.wikipedia.org/wiki/NSLU2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arm: Make ARMv5 boards work again [nuttx]

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #12825:
URL: https://github.com/apache/nuttx/pull/12825#issuecomment-2267178920

   @ldube I just tested it on LPC2378 following these steps: https://acassis.wordpress.com/2023/04/01/testing-nuttx-again-on-olimex-lpc2378-stk-board/ and same issue, board does start


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arm: Make ARMv5 boards work again [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #12825:
URL: https://github.com/apache/nuttx/pull/12825#issuecomment-2264598265

   @ldube thanks to fix this long-time regression.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org