You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Jeremias Maerki (Created) (JIRA)" <ji...@apache.org> on 2012/02/27 18:46:49 UTC

[jira] [Created] (FELIX-3364) MetaDataReader exposes a private exception class on the public API

MetaDataReader exposes a private exception class on the public API
------------------------------------------------------------------

                 Key: FELIX-3364
                 URL: https://issues.apache.org/jira/browse/FELIX-3364
             Project: Felix
          Issue Type: Bug
          Components: Metatype Service
    Affects Versions: metatype-1.0.4
            Reporter: Jeremias Maerki


MetaDataReader can be useful outside the Metatype bundle and is part of the bundle's public API. But some public methods of MetaDataReader expose XmlPullParserException which is a private class (from the embedded xmlpull):

public MetaData parse( URL url ) throws IOException, XmlPullParserException
public MetaData parse( InputStream ins ) throws IOException, XmlPullParserException

This prohibits the use of MetaDataReader from outside the Metatype bundle.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (FELIX-3364) MetaDataReader exposes a private exception class on the public API

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-3364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger reassigned FELIX-3364:
----------------------------------------

    Assignee: Felix Meschberger
    
> MetaDataReader exposes a private exception class on the public API
> ------------------------------------------------------------------
>
>                 Key: FELIX-3364
>                 URL: https://issues.apache.org/jira/browse/FELIX-3364
>             Project: Felix
>          Issue Type: Bug
>          Components: Metatype Service
>    Affects Versions: metatype-1.0.4
>            Reporter: Jeremias Maerki
>            Assignee: Felix Meschberger
>              Labels: patch
>         Attachments: xmlpullparser-visibility-patch.diff
>
>
> MetaDataReader can be useful outside the Metatype bundle and is part of the bundle's public API. But some public methods of MetaDataReader expose XmlPullParserException which is a private class (from the embedded xmlpull):
> public MetaData parse( URL url ) throws IOException, XmlPullParserException
> public MetaData parse( InputStream ins ) throws IOException, XmlPullParserException
> This prohibits the use of MetaDataReader from outside the Metatype bundle.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (FELIX-3364) MetaDataReader exposes a private exception class on the public API

Posted by "Jeremias Maerki (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-3364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeremias Maerki updated FELIX-3364:
-----------------------------------

    Attachment: xmlpullparser-visibility-patch.diff

I've created a patch that fixes the problem by throwing an IOException instead of the XMLPullParserException. That loses the original stack trace but that's probably still better than the other possible solution: exporting xmlpull. Maybe you can think of an even better approach. HTH
                
> MetaDataReader exposes a private exception class on the public API
> ------------------------------------------------------------------
>
>                 Key: FELIX-3364
>                 URL: https://issues.apache.org/jira/browse/FELIX-3364
>             Project: Felix
>          Issue Type: Bug
>          Components: Metatype Service
>    Affects Versions: metatype-1.0.4
>            Reporter: Jeremias Maerki
>              Labels: patch
>         Attachments: xmlpullparser-visibility-patch.diff
>
>
> MetaDataReader can be useful outside the Metatype bundle and is part of the bundle's public API. But some public methods of MetaDataReader expose XmlPullParserException which is a private class (from the embedded xmlpull):
> public MetaData parse( URL url ) throws IOException, XmlPullParserException
> public MetaData parse( InputStream ins ) throws IOException, XmlPullParserException
> This prohibits the use of MetaDataReader from outside the Metatype bundle.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (FELIX-3364) MetaDataReader exposes a private exception class on the public API

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-3364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger resolved FELIX-3364.
--------------------------------------

       Resolution: Fixed
    Fix Version/s:  metatype-1.0.6

Thanks for reporting and providing a patch. I have applied it in Rev. 1399648
                
> MetaDataReader exposes a private exception class on the public API
> ------------------------------------------------------------------
>
>                 Key: FELIX-3364
>                 URL: https://issues.apache.org/jira/browse/FELIX-3364
>             Project: Felix
>          Issue Type: Bug
>          Components: Metatype Service
>    Affects Versions: metatype-1.0.4
>            Reporter: Jeremias Maerki
>            Assignee: Felix Meschberger
>              Labels: patch
>             Fix For:  metatype-1.0.6
>
>         Attachments: xmlpullparser-visibility-patch.diff
>
>
> MetaDataReader can be useful outside the Metatype bundle and is part of the bundle's public API. But some public methods of MetaDataReader expose XmlPullParserException which is a private class (from the embedded xmlpull):
> public MetaData parse( URL url ) throws IOException, XmlPullParserException
> public MetaData parse( InputStream ins ) throws IOException, XmlPullParserException
> This prohibits the use of MetaDataReader from outside the Metatype bundle.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (FELIX-3364) MetaDataReader exposes a private exception class on the public API

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-3364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger closed FELIX-3364.
------------------------------------


Close after release
                
> MetaDataReader exposes a private exception class on the public API
> ------------------------------------------------------------------
>
>                 Key: FELIX-3364
>                 URL: https://issues.apache.org/jira/browse/FELIX-3364
>             Project: Felix
>          Issue Type: Bug
>          Components: Metatype Service
>    Affects Versions: metatype-1.0.4
>            Reporter: Jeremias Maerki
>            Assignee: Felix Meschberger
>              Labels: patch
>             Fix For:  metatype-1.0.6
>
>         Attachments: xmlpullparser-visibility-patch.diff
>
>
> MetaDataReader can be useful outside the Metatype bundle and is part of the bundle's public API. But some public methods of MetaDataReader expose XmlPullParserException which is a private class (from the embedded xmlpull):
> public MetaData parse( URL url ) throws IOException, XmlPullParserException
> public MetaData parse( InputStream ins ) throws IOException, XmlPullParserException
> This prohibits the use of MetaDataReader from outside the Metatype bundle.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira