[GitHub] jiazhai closed pull request #1278: Implement `toString` method for CheckpointList and BufferedLogChannel

[GitBox <gi...@apache.org>]

jiazhai closed pull request #1278: Implement `toString` method for CheckpointList and BufferedLogChannel
URL: https://github.com/apache/bookkeeper/pull/1278
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/CheckpointSource.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/CheckpointSource.java
index e7043bd32..a6b41f4c1 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/CheckpointSource.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/CheckpointSource.java
@@ -27,7 +27,7 @@
     /**
      * A checkpoint presented a time point. All entries added before this checkpoint are already persisted.
      */
-    public interface Checkpoint extends Comparable<Checkpoint> {
+    interface Checkpoint extends Comparable<Checkpoint> {
 
         Checkpoint MAX = new Checkpoint() {
 
@@ -44,6 +44,11 @@ public boolean equals(Object o) {
                 return this == o;
             }
 
+            @Override
+            public String toString() {
+                return "MAX";
+            }
+
         };
 
         Checkpoint MIN = new Checkpoint() {
@@ -59,6 +64,11 @@ public int compareTo(Checkpoint o) {
             public boolean equals(Object o) {
                 return this == o;
             }
+
+            @Override
+            public String toString() {
+                return "MIN";
+            }
         };
     }
 
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/CheckpointSourceList.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/CheckpointSourceList.java
index 64c6021e6..0c156abc9 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/CheckpointSourceList.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/CheckpointSourceList.java
@@ -19,6 +19,7 @@
 
 import static com.google.common.base.Preconditions.checkArgument;
 
+import com.google.common.base.MoreObjects;
 import com.google.common.base.Objects;
 import com.google.common.collect.Lists;
 import java.io.IOException;
@@ -109,6 +110,13 @@ public int compareTo(Checkpoint o) {
             return 0;
         }
 
+        @Override
+        public String toString() {
+            return MoreObjects.toStringHelper(CheckpointList.class)
+                .add("checkpoints", checkpoints)
+                .toString();
+        }
+
     }
 
 }
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
index 57540096b..0df8607a1 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
@@ -25,6 +25,7 @@
 import static org.apache.bookkeeper.bookie.TransactionalEntryLogCompactor.COMPACTING_SUFFIX;
 import static org.apache.bookkeeper.util.BookKeeperConstants.MAX_LOG_SIZE_LIMIT;
 
+import com.google.common.base.MoreObjects;
 import com.google.common.collect.MapMaker;
 import com.google.common.collect.Sets;
 
@@ -114,6 +115,14 @@ public void registerWrittenEntry(long ledgerId, long entrySize) {
         public ConcurrentLongLongHashMap getLedgersMap() {
             return entryLogMetadata.getLedgersMap();
         }
+
+        @Override
+        public String toString() {
+            return MoreObjects.toStringHelper(BufferedChannel.class)
+                .add("logId", logId)
+                .add("logFile", logFile)
+                .toString();
+        }
     }
 
     volatile File currentDir;


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services