You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/10/12 17:23:42 UTC
[GitHub] [geode-native] mmartell opened a new pull request #881: GEODE-9719: Start/Stop cluster in a test fixture
mmartell opened a new pull request #881:
URL: https://github.com/apache/geode-native/pull/881
This switches the NetCore test framework to Xunit fixtures. A separate fixture is used for each of the test suites (i.e., netcore-integration-test and netcore-session-integration-test. It also just creates an authRegion not separate cluster for the netcore auth tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mmartell merged pull request #881: GEODE-9719: Start/Stop cluster in a test fixture
Posted by GitBox <gi...@apache.org>.
mmartell merged pull request #881:
URL: https://github.com/apache/geode-native/pull/881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mmartell commented on pull request #881: GEODE-9719: Start/Stop cluster in a test fixture
Posted by GitBox <gi...@apache.org>.
mmartell commented on pull request #881:
URL: https://github.com/apache/geode-native/pull/881#issuecomment-941283771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mmartell commented on pull request #881: GEODE-9719: Start/Stop cluster in a test fixture
Posted by GitBox <gi...@apache.org>.
mmartell commented on pull request #881:
URL: https://github.com/apache/geode-native/pull/881#issuecomment-941283771
The build failures are not due to this PR so putting back to Ready for Review mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #881: GEODE-9719: Start/Stop cluster in a test fixture
Posted by GitBox <gi...@apache.org>.
pdxcodemonkey commented on a change in pull request #881:
URL: https://github.com/apache/geode-native/pull/881#discussion_r731252105
##########
File path: netcore/shared/GfshExecute.cs
##########
@@ -28,11 +28,19 @@ public class GfshExecute : Gfsh
private String connectionCommand_ = null;
private ITestOutputHelper output;
- public GfshExecute(ITestOutputHelper output)
+ public ITestOutputHelper Output
{
- this.output = output;
+ get { return output; }
+ set { output = value; }
}
+
+ public GfshExecute(ITestOutputHelper output)
+ {
+ //Output = output;
+ this.output = output;
+ }
Review comment:
Looks like you have a tabs vs spaces issue in this file(?). Please fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mmartell commented on pull request #881: GEODE-9719: Start/Stop cluster in a test fixture
Posted by GitBox <gi...@apache.org>.
mmartell commented on pull request #881:
URL: https://github.com/apache/geode-native/pull/881#issuecomment-941909201
Rebased against develop to pickup fix for .../integration/test/FunctionExecutionTest.cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org