You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/26 13:01:24 UTC
[GitHub] [apisix-dashboard] gxthrj opened a new pull request #883: chore: Show the correct lines of code in manager logger
gxthrj opened a new pull request #883:
URL: https://github.com/apache/apisix-dashboard/pull/883
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on pull request #883: chore: Show the correct lines of code in manager logger
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #883:
URL: https://github.com/apache/apisix-dashboard/pull/883#issuecomment-751741974
@gxthrj you need to resolve the conflict
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #883: chore: Show the correct lines of code in manager logger
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #883:
URL: https://github.com/apache/apisix-dashboard/pull/883#issuecomment-751736355
ping @gxthrj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] gxthrj commented on pull request #883: chore: Show the correct lines of code in manager logger
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #883:
URL: https://github.com/apache/apisix-dashboard/pull/883#issuecomment-734517102
ok, try to add some logger test .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #883: chore: Show the correct lines of code in manager logger
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #883:
URL: https://github.com/apache/apisix-dashboard/pull/883#issuecomment-748741171
ping @gxthrj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #883: chore: Show the correct lines of code in manager logger
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #883:
URL: https://github.com/apache/apisix-dashboard/pull/883#issuecomment-734287032
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/883?src=pr&el=h1) Report
> Merging [#883](https://codecov.io/gh/apache/apisix-dashboard/pull/883?src=pr&el=desc) (431c6c6) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/26c7743d442e9e79ec753db8ace7826e87cbc165?el=desc) (26c7743) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/883?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #883 +/- ##
=======================================
Coverage 43.03% 43.03%
=======================================
Files 18 18
Lines 1271 1271
=======================================
Hits 547 547
Misses 632 632
Partials 92 92
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/883?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/883?src=pr&el=footer). Last update [26c7743...431c6c6](https://codecov.io/gh/apache/apisix-dashboard/pull/883?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] gxthrj closed pull request #883: chore: Show the correct lines of code in manager logger
Posted by GitBox <gi...@apache.org>.
gxthrj closed pull request #883:
URL: https://github.com/apache/apisix-dashboard/pull/883
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on pull request #883: chore: Show the correct lines of code in manager logger
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #883:
URL: https://github.com/apache/apisix-dashboard/pull/883#issuecomment-734319471
@nic-chen @ShiningRush please take a look at this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #883: chore: Show the correct lines of code in manager logger
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #883:
URL: https://github.com/apache/apisix-dashboard/pull/883#issuecomment-734338541
I think we should add a cli test case for it to make sure the change works fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] gxthrj commented on pull request #883: chore: Show the correct lines of code in manager logger
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #883:
URL: https://github.com/apache/apisix-dashboard/pull/883#issuecomment-751916470
Close this issue， the caller skip has been added in other PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on pull request #883: chore: Show the correct lines of code in manager logger
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #883:
URL: https://github.com/apache/apisix-dashboard/pull/883#issuecomment-749566067
@gxthrj please fix the conflict first
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org