You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/06/06 10:58:58 UTC

[GitHub] [incubator-dolphinscheduler] yangyichao-mango opened a new pull request #2914: [Feature-2127][sql-schema] Fix the mysql version limited error (#2127)

yangyichao-mango opened a new pull request #2914:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2914


   ## What is the purpose of the pull request
   
   *Fix the mysql version and datetime sql syntax limited error for 5.5x - 5.64.*
   
   ## Brief change log
   
     - *Remove the CURRENT_TIMESTAMP in sql file.*
     - *Change the sql datetime(0) syntax to common syntax datetime, because mysql5.5x does not support the datetime(0) syntax, and datetime syntax is be in common use in mysql5.x and mysql8.x.*
     - *There is no need to set datetime in java code, because the default time was set up before.*
   
   ## Verify this pull request
   
   This pull request is code cleanup without any test coverage.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on pull request #2914: [Feature-2127][sql-schema] Fix the mysql version limited error (#2127)

Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on pull request #2914:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2914#issuecomment-647870044


   Hi @gabrywu , can you help to reopen this PR, this PR is aim to fix the 1.1.0 version mysql 5.5.x error, and it is not the repeated fix of #2915  (fix for 1.3.0) #2911 (fix for dev branch).
   Thx a lot.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] gabrywu closed pull request #2914: [Feature-2127][sql-schema] Fix the mysql version limited error (#2127)

Posted by GitBox <gi...@apache.org>.
gabrywu closed pull request #2914:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2914


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org