You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "menghaoranss (via GitHub)" <gi...@apache.org> on 2026/07/15 08:29:09 UTC
[PR] Simplify and unify identifier case policy resolution [shardingsphere]
menghaoranss opened a new pull request, #39129:
URL: https://github.com/apache/shardingsphere/pull/39129
Changes proposed in this pull request:
- Simplify and unify identifier case policy resolution
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Simplify and unify identifier case policy resolution [shardingsphere]
Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.
menghaoranss commented on PR #39129:
URL: https://github.com/apache/shardingsphere/pull/39129#issuecomment-4978866964
```markdown
### Summary
**Review Result: Mergeable**
Reason: The code-level change correctly separates protocol policy resolution from storage policy resolution, preventing a protocol provider from probing a differently typed storage data source. This result is code-scope only; CI not reviewed by request.
### Evidence
- `DatabaseIdentifierContextFactory` resolves protocol policies without a `DataSource`, and resolves storage policies using the selected storage type and its data source.
- Scope ownership remains explicit: protocol controls `SCHEMA` and `LOGICAL_TABLE`; storage supplies table-related defaults; database and storage-object compatibility scopes retain their dedicated policies.
- MySQL's no-data-source protocol path now preserves MySQL quoted identifier behavior.
- Tests cover create/refresh, heterogeneous storage detection regardless of storage-unit order, MySQL case-policy behavior, and MCP storage-policy resolution.
### Review Details
- Review Focus: Code Correctness Review. CI not reviewed by request.
- Reviewed Scope: 9 changed files in MySQL dialect, `infra/common`, MCP support, and mode core at `82d260c8ba3da100c0a44349d822101dc74fd405`; merge-base `1a7d3e67b3bb628db3f43f6b1f82c1274f5b4983`. Local triple-dot file list matched GitHub `/pulls/39129/files`.
- Not Reviewed Scope: Full-repository integration, E2E, and GitHub Actions results.
- Verification:
- `./mvnw -pl database/connector/dialect/mysql,infra/common,mode/core test ...` exited 0.
- `./mvnw -pl mcp/api,mcp/support test ...` exited 0.
- Release Note / User Docs: Not required; this is an internal identifier-policy resolution correction with no new user-facing configuration or migration requirement.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Simplify and unify identifier case policy resolution [shardingsphere]
Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.
menghaoranss merged PR #39129:
URL: https://github.com/apache/shardingsphere/pull/39129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org