You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/06/22 17:09:28 UTC

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5885: [Relay]Allow every runtime module to handle constants

zhiics commented on a change in pull request #5885:
URL: https://github.com/apache/incubator-tvm/pull/5885#discussion_r443706383



##########
File path: src/target/source/source_module.cc
##########
@@ -119,7 +122,6 @@ class CSourceModuleNode : public runtime::ModuleNode {
       return PackedFunc(
           [sptr_to_self, this](TVMArgs args, TVMRetValue* rv) { *rv = this->const_vars_; });
     } else {
-      LOG(FATAL) << "Unknown packed function: " << name;

Review comment:
       This would be needed. Your runtime could get unnecessarily stuck here for other queries.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org