You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Oleg Kalnichevski (Resolved) (JIRA)" <ji...@apache.org> on 2011/10/07 15:07:29 UTC

[jira] [Resolved] (HTTPCLIENT-1134) BasicResponseHandler Javadoc Needs Clarification

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCLIENT-1134.
-------------------------------------------

       Resolution: Fixed
    Fix Version/s: 4.2 Alpha1
                   4.1.3

You know what? There is actually no good reason for BasicResponseHandler to not consume response content in case of an unsuccessful result (status code >= 300). The change will have no effect on existing application code, will make javadocs consistent with the behavior of the handler, and this should make everyone happy.

Oleg 
                
> BasicResponseHandler Javadoc Needs Clarification
> ------------------------------------------------
>
>                 Key: HTTPCLIENT-1134
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1134
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 4.1.2
>            Reporter: David Hosier
>            Priority: Trivial
>             Fix For: 4.1.3, 4.2 Alpha1
>
>         Attachments: BasicResponseHandlerDocs.diff
>
>
> The class-level javadoc for BasicResponseHandler indicates that it reads the response body before throwing an Exception for responses with status code >= 300, which is not the case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org