You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by mike-tutkowski <gi...@git.apache.org> on 2016/11/07 20:31:39 UTC
[GitHub] cloudstack pull request #1748: KVM enhancements for managed storage
GitHub user mike-tutkowski opened a pull request:
https://github.com/apache/cloudstack/pull/1748
KVM enhancements for managed storage
This PR contains changes mainly related to enhancing managed storage on KVM. I recently added these features to a custom build of 4.5 for a prospect (and, here, I'd like to place these changes in master):
Allow zone-wide primary storage based on a custom plug-in to be added via the GUI in a KVM-only environment.
Support for root disks on managed storage with KVM
Template caching with managed storage and KVM
Support for volume snapshots with managed storage on KVM
Added the ability to revert a volume to a snapshot on KVM
Updated some integration tests
Enforce that a SolidFire volume\u2019s Min IOPS cannot exceed 15,000 and its Max and Burst IOPS cannot exceed 100,000.
A SolidFire volume must be at least one GB.
The storage driver should not remove the row from the cloud.template_spool_ref table.
Enable cluster-scoped managed storage
Only volumes from zone-wide managed storage can be storage motioned from a host in one cluster to a host in another cluster (cannot do so at the time being with volumes from cluster-scoped managed storage).
Updates for SAN-assisted snapshots
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-tutkowski/cloudstack managed-storage-enhancements-for-kvm
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1748.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1748
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1748: KVM enhancements for managed storage
Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1748
@jburwell @karuturi I went ahead and opened #1749. That one just has the fixes for #1600. That should go into 4.10 because it fixes pretty important issues and is low risk.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1748: CLOUDSTACK-9620: KVM enhancements for managed storag...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1748
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1748: KVM enhancements for managed storage
Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1748
@karuturi @jburwell Hi
I was recently working on some enhancements to 4.5 for a prospect.
Once I completed that work in their custom branch, I wanted to forward port the changes to master.
While running tests on this code, I noticed an issue related to #1600, which was merged not long ago into master.
I fixed the issues there while forward porting the code.
So, the problem is, those fixes are now embedded in this PR.
I can extract those fixes and submit a separate PR to have included in 4.10 (since it fixes an issue that was introduced in #1600), but I won't have time to run all of the managed-storage regression tests for about two weeks (since I'll be out of the country at conferences).
We could do one of the following:
1) Consider this PR for 4.10. It includes enhancements to managed storage for KVM as well as that fix for #1600. All managed-storage regression tests have been run against it (included links above) and are successful.
2) I could create a new PR with only the fixes for #1600, but I can't start running managed-storage regression tests on it until around November 22nd.
Thanks for your input.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1748: CLOUDSTACK-9620: KVM enhancements for managed storag...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1748
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-376
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1748: CLOUDSTACK-9620: KVM enhancements for managed storag...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1748
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-329
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1748: KVM enhancements for managed storage
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1748
@mike-tutkowski please get a JIRA id for this and use it in the commit summary, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1748: KVM enhancements for managed storage
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1748
@mike-tutkowski can you use the JIRA id in the commit summary as:
`CLOUDSTACK-xxxx: one-line summary
... rest of the commit message...
`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1748: KVM enhancements for managed storage
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1748
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1748: KVM enhancements for managed storage
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1748
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-175
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1748: CLOUDSTACK-9620: KVM enhancements for managed storag...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1748
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1748: CLOUDSTACK-9620: KVM enhancements for managed storag...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1748
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1748: KVM enhancements for managed storage
Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1748
@rhtyd I added that JIRA ticket and referenced it in the PR description.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1748: KVM enhancements for managed storage
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1748
@mike-tutkowski I will slot this PR into the 4.11.0.0 release. For the next release cycle, I would like to expand testing scenarios to include multi-zone, as well as, zone-wide storage which I think would be useful for regression testing this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1748: KVM enhancements for managed storage
Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1748
All tests for managed storage have been run and passed:
[results.txt](https://github.com/apache/cloudstack/files/576566/results.txt)
[results.txt](https://github.com/apache/cloudstack/files/576567/results.txt)
[results.txt](https://github.com/apache/cloudstack/files/576569/results.txt)
[results.txt](https://github.com/apache/cloudstack/files/576570/results.txt)
[results.txt](https://github.com/apache/cloudstack/files/576571/results.txt)
[results.txt](https://github.com/apache/cloudstack/files/576573/results.txt)
[results.txt](https://github.com/apache/cloudstack/files/576575/results.txt)
[results.txt](https://github.com/apache/cloudstack/files/576576/results.txt)
[results.txt](https://github.com/apache/cloudstack/files/576577/results.txt)
[results.txt](https://github.com/apache/cloudstack/files/576578/results.txt)
[results.txt](https://github.com/apache/cloudstack/files/576579/results.txt)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1748: KVM enhancements for managed storage
Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1748
@jburwell @karuturi Although I won't be able to run regression tests on #1749 anytime soon (due to being out of the country for a while), @syed has volunteered to do so.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1748: CLOUDSTACK-9620: KVM enhancements for managed storag...
Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1748
I've updated the commit summary, @rhtyd.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1748: KVM enhancements for managed storage
Posted by mike-tutkowski <gi...@git.apache.org>.
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1748
@karuturi @jburwell Oh, and just to point out, the reason I embedded those changes in this PR at the time was because I couldn't finish running my regression tests on this PR until that issue was fixed.
What happened was that #1600 passed all regression tests, but one of the things in my CloudStack environment was slightly different when I ran those same regression tests against this PR and, as such, the issue I fixed showed up. It was an easy issue to fix (it just didn't show up in a completely fresh CloudStack cloud).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1748: KVM enhancements for managed storage
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1748
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1748: CLOUDSTACK-9620: KVM enhancements for managed storag...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1748
Packaging result: \u2714centos6 \u2714centos7 \u2716debian. JID-397
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1748: CLOUDSTACK-9620: KVM enhancements for managed storag...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1748
@mike-tutkowski you please fix the git commit summary (not the PR summary) in the requested format? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1748: CLOUDSTACK-9620: KVM enhancements for managed storag...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1748
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1748: CLOUDSTACK-9620: KVM enhancements for managed storag...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1748
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1748: KVM enhancements for managed storage
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1748
Thanks @mike-tutkowski. Will take a look at #1749
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1748: CLOUDSTACK-9620: KVM enhancements for managed storag...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1748
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---