You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "zuzana-vej (via GitHub)" <gi...@apache.org> on 2026/03/18 17:42:33 UTC
[I] Editing json metadata on dashboard is now more difficult [superset]
zuzana-vej opened a new issue, #38728:
URL: https://github.com/apache/superset/issues/38728
## Screenshot
<img width="594" height="305" alt="Image" src="https://github.com/user-attachments/assets/2954f493-cc60-4c0b-86e1-bda0ff8160b1" />
## Description
The modal is not resizable and the area for json metadata so small it will be very difficult for users to make edits.
## Design input
[describe any input/collaboration you'd like from designers, and
tag accordingly. For design review, add the
label `design:review`. If this includes a design proposal,
include the label `design:suggest`]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Editing json metadata on dashboard is now more difficult [superset]
Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #38728:
URL: https://github.com/apache/superset/issues/38728#issuecomment-4084434782
<!-- Answer -->
The JSON metadata editor in the [PropertiesModal](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/dashboard/components/PropertiesModal/index.tsx#L779-L788) currently has a fixed height of 200px, which does make editing complex JSON structures difficult.
The good news is Superset's base Modal component already [supports resizability via the `re-resizable` library](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx#L175-L192), but the PropertiesModal [doesn't enable it](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/dashboard/components/PropertiesModal/index.tsx#L639). [PR #37555](https://github.com/apache/superset/pull/37555) successfully made the datasource modal resizable and draggable using this same infrastructure, so fixing this would involve enabling the `resizable` prop on the PropertiesModal following that pattern.
A similar concern was raised for the dataset edit modal in [#38215](https://github.com/apache/superset/issues/38215#issuecomment-3991858891).
<!-- Dosu Comment Footer -->
*To reply, just mention [@dosu](https://go.dosu.dev/dosubot?utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=brand-link).*
---
<sup>How did I do? [Good](https://app.dosu.dev/response-feedback/3e7a6c5a-b5ff-4674-a7b9-feb0900bdd67?feedback_type=great_response&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/3e7a6c5a-b5ff-4674-a7b9-feb0900bdd67?feedback_type=irrelevant_answer&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/3e7a6c5a-b5ff-4674-a7b9-feb0900bdd67?feedback_type=incorrect_sources&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/3e7a6c5a-b5ff-4674-a7b9-feb0900bdd67?feedback_type=too_verbose&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/3e7a6c5a-b5ff
-4674-a7b9-feb0900bdd67?feedback_type=hallucination&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/3e7a6c5a-b5ff-4674-a7b9-feb0900bdd67?feedback_type=bug_report&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-bug_report) | [Other](https://app.dosu.dev/response-feedback/3e7a6c5a-b5ff-4674-a7b9-feb0900bdd67?feedback_type=other&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-other)</sup>
[](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=chat-badge) [](https://cursor.com/link/prompt?text=The%20JSON%20metadata%20editor%20in%20the%20%5BPropertiesModal%5D%28https%3A//github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/dashboard/components/PropertiesModal/index.tsx%23L779-L788%29%20currently%20has%20a%20fixed%20height%20of%20200px%2C%20which%20does%20make%20editing%20complex%20JSON%20structures%20difficult.%0A%0AThe%20good%20news%20is%20Superset%27s%20base%20Modal%20component%20already%20%5Bsupports%20resizability%20via%20the%20%60re-resizable%60%20library%5D%28https%3A//github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/packages/superset-ui-core/src/components/Modal/Modal.tsx%23
L175-L192%29%2C%20but%20the%20PropertiesModal%20%5Bdoesn%27t%20enable%20it%5D%28https%3A//github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/dashboard/components/PropertiesModal/index.tsx%23L639%29.%20%5BPR%20%2337555%5D%28https%3A//github.com/apache/superset/pull/37555%29%20successfully%20made%20the%20datasource%20modal%20resizable%20and%20draggable%20using%20this%20same%20infrastructure%2C%20so%20fixing%20this%20would%20involve%20enabling%20the%20%60resizable%60%20prop%20on%20the%20PropertiesModal%20following%20that%20pattern.%0A%0AA%20similar%20concern%20was%20raised%20for%20the%20dataset%20edit%20modal%20in%20%5B%2338215%5D%28https%3A//github.com/apache/superset/issues/38215%23issuecomment-3991858891%29.) [](https://go.dosu.dev/discord-bot?utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=join-discord) 
;[](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/38728)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Editing json metadata on dashboard is now more difficult [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber closed issue #38728: Editing json metadata on dashboard is now more difficult
URL: https://github.com/apache/superset/issues/38728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org