[GitHub] [ozone] errose28 commented on pull request #3691: HDDS-7137. Add CLI for Getting the failed deleted block txn

[GitBox <gi...@apache.org>]

errose28 commented on PR #3691:
URL: https://github.com/apache/ozone/pull/3691#issuecomment-1229062875

   > Moving the DeletedBlocksTransaction to common hdds.proto is an ideal solution,
   but it will lead to the compatibility problem, so I adds the import of ScmServerDatanodeHeartbeatProtocol.proto
   
   I don't think we want this dependency chain. hdds.proto exists to prevent the admin and heartbeat proto from depending on each other. Cross client and rolling upgrade compatability (future work) will be harder to maintain with this dependency. The DeletedBlocksTransaction message is not very complicated. Could we make a different version of that message to be used in the client response placed in ScmAdminProtocol.proto?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org