[GitHub] [pulsar] rdhabalia commented on a diff in pull request #19696: [fix][cli] Fix Pulsar admin tool is ignoring tls-trust-cert path arg

["rdhabalia (via GitHub)" <gi...@apache.org>]

rdhabalia commented on code in PR #19696:
URL: https://github.com/apache/pulsar/pull/19696#discussion_r1123838388


##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminSupplier.java:
##########
@@ -103,6 +103,9 @@ private static void applyRootParamsToAdminBuilder(PulsarAdminBuilder adminBuilde
         if (isNotBlank(rootParams.tlsProvider)) {
             adminBuilder.sslProvider(rootParams.tlsProvider);
         }
+        if (isNotBlank(rootParams.tlsTrustCertsFilePath)) {
+            adminBuilder.tlsTrustCertsFilePath(rootParams.tlsTrustCertsFilePath);

Review Comment:
   @michaeljmarshall there are two ways to configure variables: configure in conf file or pass as arguments in CLI. right now, it only reads from `conf/client.conf` file but it ignores if user provide as a cli argument that's because it doesn't check `rootParams.tlsTrustCertsFilePath` which is parsed as CLI args.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org