You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/02/13 19:31:32 UTC

[Impala-ASF-CR] IMPALA-8097: mt dop for all queries via hidden flag

Hello Michael Ho, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12257

to look at the new patch set (#7).

Change subject: IMPALA-8097: mt_dop for all queries via hidden flag
......................................................................

IMPALA-8097: mt_dop for all queries via hidden flag

--unlock_mt_dop=true unlocks mt_dop for all queries
including joins and inserts.

This disables the parallel plans with separate join builds
when running standalone, because these are not executable
until IMPALA-4224 is implemented. Inserts work without
modification - they were disabled because of lack of
testing and the possibility for generating many small
files with unpartitioned inserts - see IMPALA-8125.

Testing:
Add custom cluster test that exercise joins, runtime filters
and inserts as a sanity check for the flag.

Ran exhaustive build.

Manually ran TPC-H and TPC-DS tests against a minicluster
with mt_dop = 4.

Change-Id: I72f0b02a005e8bf22fd17b8fb5aabf8c0d9b6b15
---
M be/src/common/global-flags.cc
M be/src/exec/blocking-join-node.cc
M be/src/exec/partitioned-hash-join-builder.cc
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator.cc
M be/src/util/backend-gflag-util.cc
M common/thrift/BackendGflags.thrift
M fe/src/main/java/org/apache/impala/planner/Planner.java
M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
M fe/src/main/java/org/apache/impala/service/BackendConfig.java
A testdata/workloads/functional-query/queries/QueryTest/joins_mt_dop.test
A tests/custom_cluster/test_mt_dop.py
12 files changed, 121 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/12257/7
-- 
To view, visit http://gerrit.cloudera.org:8080/12257
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I72f0b02a005e8bf22fd17b8fb5aabf8c0d9b6b15
Gerrit-Change-Number: 12257
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>