[jira] [Resolved] (HIVE-18124) clean up isAcidTable() API vs isInsertOnlyTable()

["Eugene Koifman (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eugene Koifman resolved HIVE-18124.
-----------------------------------
       Resolution: Fixed
    Fix Version/s: 3.0.0

patch 7 attached for completeness - includes additional doc comments in AcidUtils.AcidOperationalProperties
committed to master
thanks Alan for the review

>  clean up isAcidTable() API vs isInsertOnlyTable()
> --------------------------------------------------
>
>                 Key: HIVE-18124
>                 URL: https://issues.apache.org/jira/browse/HIVE-18124
>             Project: Hive
>          Issue Type: Bug
>          Components: Transactions
>    Affects Versions: 3.0.0
>            Reporter: Eugene Koifman
>            Assignee: Eugene Koifman
>             Fix For: 3.0.0
>
>         Attachments: HIVE-18124.01.patch, HIVE-18124.02.patch, HIVE-18124.03.patch, HIVE-18124.04.patch, HIVE-18124.05.patch, HIVE-18124.06.patch, HIVE-18124.07.patch
>
>
> With the addition of MM tables (_AcidUtils.isInsertOnlyTable(table)_) the methods in AcidUtils and dependent places are very muddled.  There are now a number of places where we have something like _isAcidTable = AcidUtils.isFullAcidTable(table)_  and a later getter
> _boolean isAcidTable() \{ return isAcidTable;\}_
> Need to clean it up so that there is a isTransactional(Table) that checks transactional=true setting and isAcid(Table) to mean full ACID and isInsertOnly(Table) to mean MM tables.
> This would accurately describe the semantics of the tables.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)