[jira] [Commented] (TINKERPOP3-906) Revise DependencyGrabberTest to not be order dependent

["Jason Plurad (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP3-906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976543#comment-14976543 ] 

Jason Plurad commented on TINKERPOP3-906:
-----------------------------------------

I believe I've gotten to the bottom of this.

It turns out that there is a bug in Groovy Grapes. When there is a failed call to {{Grape.resolve()}}, {{GrapeIvy.resolve()}} hangs onto a reference to the IvyGrabRecord for the failed dependency. When subsequent {{resolve()}} calls are made, those failed records are still there, so it will continue to fail from that point on. This explains why the ordering was important in the TinkerPop test case.

https://github.com/apache/incubator-groovy/blob/GROOVY_2_4_1/src/main/groovy/grape/GrapeIvy.groovy#L404

Note that {{grab()}} cleans up correctly on a failed grab.

https://github.com/apache/incubator-groovy/blob/GROOVY_2_4_1/src/main/groovy/grape/GrapeIvy.groovy#L265-L268

I'll get a JIRA opened up against Groovy for this and then link it back in here.

In the meantime, it is probably best to ignore the {{shouldThrowRuntimeException}} test case.


> Revise DependencyGrabberTest to not be order dependent
> ------------------------------------------------------
>
>                 Key: TINKERPOP3-906
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP3-906
>             Project: TinkerPop 3
>          Issue Type: Improvement
>          Components: groovy
>    Affects Versions: 3.0.2-incubating
>            Reporter: stephen mallette
>            Assignee: Jason Plurad
>             Fix For: 3.1.0-incubating
>
>
> The {{DependencyGrabberTest}} currently require ordered execution based on the name of the test.  In some environments this seems to cause the tests to fail (as they may execute out of order).  Generally speaking though it seems it would be best if the tests didn't have dependencies on each other in order to pass.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)