You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/07 16:25:55 UTC
[GitHub] [flink] tillrohrmann opened a new pull request #12026: [FLINK-17554] Allow to register release hooks for the user code class loader
tillrohrmann opened a new pull request #12026:
URL: https://github.com/apache/flink/pull/12026
cc @StephanEwen would this help for the `FlinkKinesisConsumer` to release its classes? It is basically what you mentioned in our sync.
## What is the purpose of the change
TBF
## Brief change log
TBF
## Verifying this change
TBF
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12026: [FLINK-17554] Allow to register release hooks for the user code class loader
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12026:
URL: https://github.com/apache/flink/pull/12026#issuecomment-625378377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11f33a325dbc730a2ce800097ac0de391626ef23",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11f33a325dbc730a2ce800097ac0de391626ef23",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11f33a325dbc730a2ce800097ac0de391626ef23 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #12026: [FLINK-17554] Allow to register release hooks for the user code class loader
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #12026:
URL: https://github.com/apache/flink/pull/12026#issuecomment-688899801
I'm closing this PR as I've opened a new one based on this work: https://github.com/apache/flink/pull/13355
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12026: [FLINK-17554] Allow to register release hooks for the user code class loader
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12026:
URL: https://github.com/apache/flink/pull/12026#issuecomment-625360141
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 11f33a325dbc730a2ce800097ac0de391626ef23 (Thu May 07 16:28:04 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12026: [FLINK-17554] Allow to register release hooks for the user code class loader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12026:
URL: https://github.com/apache/flink/pull/12026#issuecomment-625378377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11f33a325dbc730a2ce800097ac0de391626ef23",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=769",
"triggerID" : "11f33a325dbc730a2ce800097ac0de391626ef23",
"triggerType" : "PUSH"
}, {
"hash" : "4b1c814287a70b7ed09522ad0aec0e91fe41496c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4b1c814287a70b7ed09522ad0aec0e91fe41496c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11f33a325dbc730a2ce800097ac0de391626ef23 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=769)
* 4b1c814287a70b7ed09522ad0aec0e91fe41496c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12026: [FLINK-17554] Allow to register release hooks for the user code class loader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12026:
URL: https://github.com/apache/flink/pull/12026#issuecomment-625378377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11f33a325dbc730a2ce800097ac0de391626ef23",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=769",
"triggerID" : "11f33a325dbc730a2ce800097ac0de391626ef23",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11f33a325dbc730a2ce800097ac0de391626ef23 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=769)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger closed pull request #12026: [FLINK-17554] Allow to register release hooks for the user code class loader
Posted by GitBox <gi...@apache.org>.
rmetzger closed pull request #12026:
URL: https://github.com/apache/flink/pull/12026
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12026: [FLINK-17554] Allow to register release hooks for the user code class loader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12026:
URL: https://github.com/apache/flink/pull/12026#issuecomment-625378377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11f33a325dbc730a2ce800097ac0de391626ef23",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=769",
"triggerID" : "11f33a325dbc730a2ce800097ac0de391626ef23",
"triggerType" : "PUSH"
}, {
"hash" : "4b1c814287a70b7ed09522ad0aec0e91fe41496c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=772",
"triggerID" : "4b1c814287a70b7ed09522ad0aec0e91fe41496c",
"triggerType" : "PUSH"
}, {
"hash" : "18d8eed558e7f8b0b8538cf26b4ce3f6f5308198",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "18d8eed558e7f8b0b8538cf26b4ce3f6f5308198",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4b1c814287a70b7ed09522ad0aec0e91fe41496c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=772)
* 18d8eed558e7f8b0b8538cf26b4ce3f6f5308198 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12026: [FLINK-17554] Allow to register release hooks for the user code class loader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12026:
URL: https://github.com/apache/flink/pull/12026#issuecomment-625378377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11f33a325dbc730a2ce800097ac0de391626ef23",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=769",
"triggerID" : "11f33a325dbc730a2ce800097ac0de391626ef23",
"triggerType" : "PUSH"
}, {
"hash" : "4b1c814287a70b7ed09522ad0aec0e91fe41496c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=772",
"triggerID" : "4b1c814287a70b7ed09522ad0aec0e91fe41496c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4b1c814287a70b7ed09522ad0aec0e91fe41496c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=772)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12026: [FLINK-17554] Allow to register release hooks for the user code class loader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12026:
URL: https://github.com/apache/flink/pull/12026#issuecomment-625378377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11f33a325dbc730a2ce800097ac0de391626ef23",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=769",
"triggerID" : "11f33a325dbc730a2ce800097ac0de391626ef23",
"triggerType" : "PUSH"
}, {
"hash" : "4b1c814287a70b7ed09522ad0aec0e91fe41496c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=772",
"triggerID" : "4b1c814287a70b7ed09522ad0aec0e91fe41496c",
"triggerType" : "PUSH"
}, {
"hash" : "18d8eed558e7f8b0b8538cf26b4ce3f6f5308198",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=961",
"triggerID" : "18d8eed558e7f8b0b8538cf26b4ce3f6f5308198",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18d8eed558e7f8b0b8538cf26b4ce3f6f5308198 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=961)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12026: [FLINK-17554] Allow to register release hooks for the user code class loader
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12026:
URL: https://github.com/apache/flink/pull/12026#issuecomment-625378377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "11f33a325dbc730a2ce800097ac0de391626ef23",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=769",
"triggerID" : "11f33a325dbc730a2ce800097ac0de391626ef23",
"triggerType" : "PUSH"
}, {
"hash" : "4b1c814287a70b7ed09522ad0aec0e91fe41496c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=772",
"triggerID" : "4b1c814287a70b7ed09522ad0aec0e91fe41496c",
"triggerType" : "PUSH"
}, {
"hash" : "18d8eed558e7f8b0b8538cf26b4ce3f6f5308198",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=961",
"triggerID" : "18d8eed558e7f8b0b8538cf26b4ce3f6f5308198",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4b1c814287a70b7ed09522ad0aec0e91fe41496c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=772)
* 18d8eed558e7f8b0b8538cf26b4ce3f6f5308198 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=961)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org