You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Paul Libbrecht <pa...@activemath.org> on 2009/09/11 16:45:07 UTC
[jexl] has ExpressionFactory disappeared? (was Re: [GUMP@vmgump]: Project commons-jelly (in module commons-jelly) failed)
Hello Jexl developers,
has ExpressionFactory disappeared?
Did package-names maybe change?
I guess I would appreciate to revert that bit, maybe by explicitly
depending on jexl 1?
paul
Le 11-sept.-09 à 13:43, commons-jelly development (running Gump) a
écrit :
> [javac] /srv/gump/public/workspace/commons-jelly/src/java/org/
> apache/commons/jelly/expression/jexl/JexlExpressionFactory.java:63:
> cannot find symbol
> [javac] symbol : class ExpressionFactory
> [javac] location: package org.apache.commons.jexl
> [javac]
> org.apache.commons.jexl.ExpressionFactory.createExpression(text)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [jexl] has ExpressionFactory disappeared? (was Re:
[GUMP@vmgump]: Project commons-jelly (in module commons-jelly) failed)
Posted by Henrib <hb...@gmail.com>.
There was more than just the JexlArithmetic problemfrom what I could gather;
Exception handling was also a bit different. Things should be in order now.
URL: http://svn.apache.org/viewvc?rev=814637&view=rev
Log:
Made {Expression,Script}Factory use a specialized 'legacy' interpreter that
more strictly mimicks JEXL 1.1 behavior, at least according to Jelly
expectations (Jelly tests pass locally now).
Introduced undefinedVariable and invocationError methods in Interpreter.java
to allow easier derivation.
Enhanced error reporting in JexlEngine#parse to go down further in stack
seeking caller.
--
View this message in context: http://www.nabble.com/-GUMP%40vmgump-%3A-Project-commons-jelly-%28in-module-commons-jelly%29-failed-tp25399459p25436053.html
Sent from the Commons - Dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [jexl] has ExpressionFactory disappeared? (was Re: [GUMP@vmgump]:
Project commons-jelly (in module commons-jelly) failed)
Posted by sebb <se...@gmail.com>.
On 13/09/2009, Henrib <hb...@gmail.com> wrote:
>
> Seems like integer (long versus int in test assertions) from what I could
> dig.
>
Yes, just found that too.
This is a recent change in JEXL.
The code is comparing file.length*2 with file.length - the former is
being downcast to an Integer, which is wrong.
>
> sebb-2-2 wrote:
> >
> > On 13/09/2009, sebb <se...@gmail.com> wrote:
> >> On 12/09/2009, Rahul Akolkar <ra...@gmail.com> wrote:
> >> > On Sat, Sep 12, 2009 at 9:49 AM, sebb <se...@gmail.com> wrote:
> >> > > On 12/09/2009, sebb <se...@gmail.com> wrote:
> >> > >> On 12/09/2009, Rahul Akolkar <ra...@gmail.com> wrote:
> >> > >> > On Fri, Sep 11, 2009 at 10:45 AM, Paul Libbrecht
> >> <pa...@activemath.org> wrote:
> >> > >> > > Hello Jexl developers,
> >> > >> > >
> >> > >> > > has ExpressionFactory disappeared?
> >> > >> > > Did package-names maybe change?
> >> > >> > >
> >> > >> > > I guess I would appreciate to revert that bit, maybe by
> >> explicitly depending
> >> > >> > > on jexl 1?
> >> > >> > >
> >> > >> >
> >> > >> > <snip/>
> >> > >> >
> >> > >> > You could depend on 1.1, yes.
> >> > >> >
> >> > >> > As gump is pointing out though, this is one breakage that'll
> >> be in
> >> > >> > parts seeing widespread use. On the JEXL side, thinking its
> >> best to
> >> > >> > add deprecated Expression/ScriptFactory versions that delegate
> >> to the
> >> > >> > JexlEngine API.
> >> > >>
> >> > >>
> >> > >> +1
> >> > >>
> >> > >
> >> > > Just noticed that we both agreed to removing these classes - see
> >> JEXL-72.
> >> > >
> >> > > It looks as though the classes were only deprecated in the 2.0 code
> >> > > line, so I guess we should not be removing them yet.
> >> >
> >> > <snip/>
> >> >
> >> > Gump is deftly persuasive -- the cleaner, less redundant API will
> >> have
> >> > to wait. So yes, best to reopen JEXL-72.
> >> >
> >>
> >>
> >> Gump is now happy again.
> >
> > Wrote too soon! Although the compilation errors have gone, the test
> > suite has some errors (e.g. variables not defined).
> >
> >> The deprecated methods now create a new JEXL engine each time, whereas
> >> previously they shared a static instance of the engine. Is that
> >> reasonable, or should the code try to be closer to the original and
> >> use a shared instance?
> >
> > The test errors look as though the Jelly tests may be depending on a
> > shared engine. I'll take a look at this shortly.
> >
> >>
> >> > -Rahul
> >> >
> >> >
> >> > ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> > For additional commands, e-mail: dev-help@commons.apache.org
> >> >
> >> >
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
> >
>
>
> --
> View this message in context: http://www.nabble.com/-GUMP%40vmgump-%3A-Project-commons-jelly-%28in-module-commons-jelly%29-failed-tp25399459p25427936.html
> Sent from the Commons - Dev mailing list archive at Nabble.com.
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [jexl] has ExpressionFactory disappeared? (was Re:
[GUMP@vmgump]: Project commons-jelly (in module commons-jelly) failed)
Posted by Henrib <hb...@gmail.com>.
Seems like integer (long versus int in test assertions) from what I could
dig.
sebb-2-2 wrote:
>
> On 13/09/2009, sebb <se...@gmail.com> wrote:
>> On 12/09/2009, Rahul Akolkar <ra...@gmail.com> wrote:
>> > On Sat, Sep 12, 2009 at 9:49 AM, sebb <se...@gmail.com> wrote:
>> > > On 12/09/2009, sebb <se...@gmail.com> wrote:
>> > >> On 12/09/2009, Rahul Akolkar <ra...@gmail.com> wrote:
>> > >> > On Fri, Sep 11, 2009 at 10:45 AM, Paul Libbrecht
>> <pa...@activemath.org> wrote:
>> > >> > > Hello Jexl developers,
>> > >> > >
>> > >> > > has ExpressionFactory disappeared?
>> > >> > > Did package-names maybe change?
>> > >> > >
>> > >> > > I guess I would appreciate to revert that bit, maybe by
>> explicitly depending
>> > >> > > on jexl 1?
>> > >> > >
>> > >> >
>> > >> > <snip/>
>> > >> >
>> > >> > You could depend on 1.1, yes.
>> > >> >
>> > >> > As gump is pointing out though, this is one breakage that'll
>> be in
>> > >> > parts seeing widespread use. On the JEXL side, thinking its
>> best to
>> > >> > add deprecated Expression/ScriptFactory versions that delegate
>> to the
>> > >> > JexlEngine API.
>> > >>
>> > >>
>> > >> +1
>> > >>
>> > >
>> > > Just noticed that we both agreed to removing these classes - see
>> JEXL-72.
>> > >
>> > > It looks as though the classes were only deprecated in the 2.0 code
>> > > line, so I guess we should not be removing them yet.
>> >
>> > <snip/>
>> >
>> > Gump is deftly persuasive -- the cleaner, less redundant API will
>> have
>> > to wait. So yes, best to reopen JEXL-72.
>> >
>>
>>
>> Gump is now happy again.
>
> Wrote too soon! Although the compilation errors have gone, the test
> suite has some errors (e.g. variables not defined).
>
>> The deprecated methods now create a new JEXL engine each time, whereas
>> previously they shared a static instance of the engine. Is that
>> reasonable, or should the code try to be closer to the original and
>> use a shared instance?
>
> The test errors look as though the Jelly tests may be depending on a
> shared engine. I'll take a look at this shortly.
>
>>
>> > -Rahul
>> >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> > For additional commands, e-mail: dev-help@commons.apache.org
>> >
>> >
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
>
--
View this message in context: http://www.nabble.com/-GUMP%40vmgump-%3A-Project-commons-jelly-%28in-module-commons-jelly%29-failed-tp25399459p25427936.html
Sent from the Commons - Dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [jexl] has ExpressionFactory disappeared? (was Re: [GUMP@vmgump]:
Project commons-jelly (in module commons-jelly) failed)
Posted by sebb <se...@gmail.com>.
On 13/09/2009, sebb <se...@gmail.com> wrote:
> On 12/09/2009, Rahul Akolkar <ra...@gmail.com> wrote:
> > On Sat, Sep 12, 2009 at 9:49 AM, sebb <se...@gmail.com> wrote:
> > > On 12/09/2009, sebb <se...@gmail.com> wrote:
> > >> On 12/09/2009, Rahul Akolkar <ra...@gmail.com> wrote:
> > >> > On Fri, Sep 11, 2009 at 10:45 AM, Paul Libbrecht <pa...@activemath.org> wrote:
> > >> > > Hello Jexl developers,
> > >> > >
> > >> > > has ExpressionFactory disappeared?
> > >> > > Did package-names maybe change?
> > >> > >
> > >> > > I guess I would appreciate to revert that bit, maybe by explicitly depending
> > >> > > on jexl 1?
> > >> > >
> > >> >
> > >> > <snip/>
> > >> >
> > >> > You could depend on 1.1, yes.
> > >> >
> > >> > As gump is pointing out though, this is one breakage that'll be in
> > >> > parts seeing widespread use. On the JEXL side, thinking its best to
> > >> > add deprecated Expression/ScriptFactory versions that delegate to the
> > >> > JexlEngine API.
> > >>
> > >>
> > >> +1
> > >>
> > >
> > > Just noticed that we both agreed to removing these classes - see JEXL-72.
> > >
> > > It looks as though the classes were only deprecated in the 2.0 code
> > > line, so I guess we should not be removing them yet.
> >
> > <snip/>
> >
> > Gump is deftly persuasive -- the cleaner, less redundant API will have
> > to wait. So yes, best to reopen JEXL-72.
> >
>
>
> Gump is now happy again.
Wrote too soon! Although the compilation errors have gone, the test
suite has some errors (e.g. variables not defined).
> The deprecated methods now create a new JEXL engine each time, whereas
> previously they shared a static instance of the engine. Is that
> reasonable, or should the code try to be closer to the original and
> use a shared instance?
The test errors look as though the Jelly tests may be depending on a
shared engine. I'll take a look at this shortly.
>
> > -Rahul
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [jexl] has ExpressionFactory disappeared? (was Re: [GUMP@vmgump]:
Project commons-jelly (in module commons-jelly) failed)
Posted by sebb <se...@gmail.com>.
On 12/09/2009, Rahul Akolkar <ra...@gmail.com> wrote:
> On Sat, Sep 12, 2009 at 9:49 AM, sebb <se...@gmail.com> wrote:
> > On 12/09/2009, sebb <se...@gmail.com> wrote:
> >> On 12/09/2009, Rahul Akolkar <ra...@gmail.com> wrote:
> >> > On Fri, Sep 11, 2009 at 10:45 AM, Paul Libbrecht <pa...@activemath.org> wrote:
> >> > > Hello Jexl developers,
> >> > >
> >> > > has ExpressionFactory disappeared?
> >> > > Did package-names maybe change?
> >> > >
> >> > > I guess I would appreciate to revert that bit, maybe by explicitly depending
> >> > > on jexl 1?
> >> > >
> >> >
> >> > <snip/>
> >> >
> >> > You could depend on 1.1, yes.
> >> >
> >> > As gump is pointing out though, this is one breakage that'll be in
> >> > parts seeing widespread use. On the JEXL side, thinking its best to
> >> > add deprecated Expression/ScriptFactory versions that delegate to the
> >> > JexlEngine API.
> >>
> >>
> >> +1
> >>
> >
> > Just noticed that we both agreed to removing these classes - see JEXL-72.
> >
> > It looks as though the classes were only deprecated in the 2.0 code
> > line, so I guess we should not be removing them yet.
>
> <snip/>
>
> Gump is deftly persuasive -- the cleaner, less redundant API will have
> to wait. So yes, best to reopen JEXL-72.
>
Gump is now happy again.
The deprecated methods now create a new JEXL engine each time, whereas
previously they shared a static instance of the engine. Is that
reasonable, or should the code try to be closer to the original and
use a shared instance?
> -Rahul
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [jexl] has ExpressionFactory disappeared? (was Re: [GUMP@vmgump]:
Project commons-jelly (in module commons-jelly) failed)
Posted by Rahul Akolkar <ra...@gmail.com>.
On Sat, Sep 12, 2009 at 9:49 AM, sebb <se...@gmail.com> wrote:
> On 12/09/2009, sebb <se...@gmail.com> wrote:
>> On 12/09/2009, Rahul Akolkar <ra...@gmail.com> wrote:
>> > On Fri, Sep 11, 2009 at 10:45 AM, Paul Libbrecht <pa...@activemath.org> wrote:
>> > > Hello Jexl developers,
>> > >
>> > > has ExpressionFactory disappeared?
>> > > Did package-names maybe change?
>> > >
>> > > I guess I would appreciate to revert that bit, maybe by explicitly depending
>> > > on jexl 1?
>> > >
>> >
>> > <snip/>
>> >
>> > You could depend on 1.1, yes.
>> >
>> > As gump is pointing out though, this is one breakage that'll be in
>> > parts seeing widespread use. On the JEXL side, thinking its best to
>> > add deprecated Expression/ScriptFactory versions that delegate to the
>> > JexlEngine API.
>>
>>
>> +1
>>
>
> Just noticed that we both agreed to removing these classes - see JEXL-72.
>
> It looks as though the classes were only deprecated in the 2.0 code
> line, so I guess we should not be removing them yet.
<snip/>
Gump is deftly persuasive -- the cleaner, less redundant API will have
to wait. So yes, best to reopen JEXL-72.
-Rahul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [jexl] has ExpressionFactory disappeared? (was Re: [GUMP@vmgump]:
Project commons-jelly (in module commons-jelly) failed)
Posted by sebb <se...@gmail.com>.
On 12/09/2009, sebb <se...@gmail.com> wrote:
> On 12/09/2009, Rahul Akolkar <ra...@gmail.com> wrote:
> > On Fri, Sep 11, 2009 at 10:45 AM, Paul Libbrecht <pa...@activemath.org> wrote:
> > > Hello Jexl developers,
> > >
> > > has ExpressionFactory disappeared?
> > > Did package-names maybe change?
> > >
> > > I guess I would appreciate to revert that bit, maybe by explicitly depending
> > > on jexl 1?
> > >
> >
> > <snip/>
> >
> > You could depend on 1.1, yes.
> >
> > As gump is pointing out though, this is one breakage that'll be in
> > parts seeing widespread use. On the JEXL side, thinking its best to
> > add deprecated Expression/ScriptFactory versions that delegate to the
> > JexlEngine API.
>
>
> +1
>
Just noticed that we both agreed to removing these classes - see JEXL-72.
It looks as though the classes were only deprecated in the 2.0 code
line, so I guess we should not be removing them yet.
> >
> > -Rahul
> >
> >
> >
> > > paul
> > >
> > > Le 11-sept.-09 à 13:43, commons-jelly development (running Gump) a écrit :
> > >
> > >> [javac]
> > >> /srv/gump/public/workspace/commons-jelly/src/java/org/apache/commons/jelly/expression/jexl/JexlExpressionFactory.java:63:
> > >> cannot find symbol
> > >> [javac] symbol : class ExpressionFactory
> > >> [javac] location: package org.apache.commons.jexl
> > >> [javac]
> > >> org.apache.commons.jexl.ExpressionFactory.createExpression(text)
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [jexl] has ExpressionFactory disappeared? (was Re: [GUMP@vmgump]:
Project commons-jelly (in module commons-jelly) failed)
Posted by sebb <se...@gmail.com>.
On 12/09/2009, Rahul Akolkar <ra...@gmail.com> wrote:
> On Fri, Sep 11, 2009 at 10:45 AM, Paul Libbrecht <pa...@activemath.org> wrote:
> > Hello Jexl developers,
> >
> > has ExpressionFactory disappeared?
> > Did package-names maybe change?
> >
> > I guess I would appreciate to revert that bit, maybe by explicitly depending
> > on jexl 1?
> >
>
> <snip/>
>
> You could depend on 1.1, yes.
>
> As gump is pointing out though, this is one breakage that'll be in
> parts seeing widespread use. On the JEXL side, thinking its best to
> add deprecated Expression/ScriptFactory versions that delegate to the
> JexlEngine API.
+1
>
> -Rahul
>
>
>
> > paul
> >
> > Le 11-sept.-09 à 13:43, commons-jelly development (running Gump) a écrit :
> >
> >> [javac]
> >> /srv/gump/public/workspace/commons-jelly/src/java/org/apache/commons/jelly/expression/jexl/JexlExpressionFactory.java:63:
> >> cannot find symbol
> >> [javac] symbol : class ExpressionFactory
> >> [javac] location: package org.apache.commons.jexl
> >> [javac]
> >> org.apache.commons.jexl.ExpressionFactory.createExpression(text)
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [jexl] has ExpressionFactory disappeared? (was Re: [GUMP@vmgump]:
Project commons-jelly (in module commons-jelly) failed)
Posted by Rahul Akolkar <ra...@gmail.com>.
On Fri, Sep 11, 2009 at 10:45 AM, Paul Libbrecht <pa...@activemath.org> wrote:
> Hello Jexl developers,
>
> has ExpressionFactory disappeared?
> Did package-names maybe change?
>
> I guess I would appreciate to revert that bit, maybe by explicitly depending
> on jexl 1?
>
<snip/>
You could depend on 1.1, yes.
As gump is pointing out though, this is one breakage that'll be in
parts seeing widespread use. On the JEXL side, thinking its best to
add deprecated Expression/ScriptFactory versions that delegate to the
JexlEngine API.
-Rahul
> paul
>
> Le 11-sept.-09 à 13:43, commons-jelly development (running Gump) a écrit :
>
>> [javac]
>> /srv/gump/public/workspace/commons-jelly/src/java/org/apache/commons/jelly/expression/jexl/JexlExpressionFactory.java:63:
>> cannot find symbol
>> [javac] symbol : class ExpressionFactory
>> [javac] location: package org.apache.commons.jexl
>> [javac]
>> org.apache.commons.jexl.ExpressionFactory.createExpression(text)
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org