You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/18 18:37:36 UTC
[GitHub] [airflow] mik-laj opened a new issue #8439: Clean up the
test_variable_commnand.py file.
mik-laj opened a new issue #8439: Clean up the test_variable_commnand.py file.
URL: https://github.com/apache/airflow/issues/8439
Hello,
There is some mess in this file. All commands are tested in one method, which makes it difficult to develop these commands.
https://raw.githubusercontent.com/apache/airflow/17fc9c541ea4aecbd5ae566a11f6601b4038b197/tests/cli/commands/test_variable_command.py
I would be happy if each command was tested in a separate method and if there were no side effects between tests.
Additional points can be obtained if you add an assertion that will check the content of the file during export and import.
Best regards,
Kamil
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] Kopurlso commented on issue #8439: Clean up the
test_variable_commnand.py file.
Posted by GitBox <gi...@apache.org>.
Kopurlso commented on issue #8439: Clean up the test_variable_commnand.py file.
URL: https://github.com/apache/airflow/issues/8439#issuecomment-615946596
Hey @mik-laj I'm a bit of a beginner, but I'd love to try my hand at this issue, if I'm understanding the ask correctly, you want to refactor out each variable_command method into its own testing method for easier testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #8439: Clean up the
test_variable_commnand.py file.
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #8439: Clean up the test_variable_commnand.py file.
URL: https://github.com/apache/airflow/issues/8439#issuecomment-615947215
Yes. I want to divide one large test method into several smaller ones.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services