Re: [PR] fix(aggregate): show aliased expr in explain [datafusion]

["kumarUjjawal (via GitHub)" <gi...@apache.org>]

kumarUjjawal commented on code in PR #21739:
URL: https://github.com/apache/datafusion/pull/21739#discussion_r3174437285


##########
datafusion/physical-expr/src/aggregate.rs:
##########
@@ -347,8 +375,13 @@ impl AggregateFunctionExpr {
     }
 
     /// Simplified name for `tree` explain.
-    pub fn human_display(&self) -> &str {
-        &self.human_display
+    pub fn human_display(&self) -> Option<&str> {
+        self.human_display.as_deref()
+    }
+
+    #[doc(hidden)]
+    pub fn has_aliased_human_display(&self) -> bool {
+        self.human_display_is_aliased

Review Comment:
   Let me try this and see how it turn out.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org