[GitHub] kramasamy closed pull request #2848: Rate limit needs to be disabled before the bufferevent_free call

[GitBox <gi...@apache.org>]

kramasamy closed pull request #2848: Rate limit needs to be disabled before the bufferevent_free call
URL: https://github.com/apache/incubator-heron/pull/2848
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/heron/common/src/cpp/network/baseconnection.cpp b/heron/common/src/cpp/network/baseconnection.cpp
index e992cd9989..28442a6682 100644
--- a/heron/common/src/cpp/network/baseconnection.cpp
+++ b/heron/common/src/cpp/network/baseconnection.cpp
@@ -57,8 +57,8 @@ BaseConnection::BaseConnection(ConnectionEndPoint* endpoint, ConnectionOptions*
 
 BaseConnection::~BaseConnection() {
   CHECK(mState == INIT || mState == DISCONNECTED);
-  bufferevent_free(buffer_);
   disableRateLimit();  // To free the config object
+  bufferevent_free(buffer_);
 }
 
 sp_int32 BaseConnection::start() {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services