You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2010/08/18 18:22:18 UTC
[jira] Created: (CASSANDRA-1405) Switch to THsHaServer, redux
Switch to THsHaServer, redux
----------------------------
Key: CASSANDRA-1405
URL: https://issues.apache.org/jira/browse/CASSANDRA-1405
Project: Cassandra
Issue Type: Improvement
Components: Core
Reporter: Jonathan Ellis
Assignee: Brandon Williams
Priority: Minor
Fix For: 0.7.0
Brian's patch to CASSANDRA-876 suggested using a custom TProcessorFactory subclass, overriding getProcessor to reset to a default state when a new client connects. It looks like this would allow dropping CustomTThreadPoolServer as well as allowing non-thread based servers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1405) Switch to THsHaServer, redux
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915897#action_12915897 ]
Brandon Williams commented on CASSANDRA-1405:
---------------------------------------------
To do this, we'll need to make a CassandraServer.instance so that getProcessor has a way to get to it to reset the ClientState (Brian's approach for CASSANDRA-876 did this using StorageService.instance, which was already there.)
> Switch to THsHaServer, redux
> ----------------------------
>
> Key: CASSANDRA-1405
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1405
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Brandon Williams
> Priority: Minor
> Fix For: 0.7.0
>
>
> Brian's patch to CASSANDRA-876 suggested using a custom TProcessorFactory subclass, overriding getProcessor to reset to a default state when a new client connects. It looks like this would allow dropping CustomTThreadPoolServer as well as allowing non-thread based servers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1405) Switch to THsHaServer, redux
Posted by "Benjamin Coverston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Coverston updated CASSANDRA-1405:
------------------------------------------
Attachment: (was: trunk-1405v6.patch)
> Switch to THsHaServer, redux
> ----------------------------
>
> Key: CASSANDRA-1405
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1405
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 0.7.1
>
> Attachments: libthrift-r1026391.jar, trunk-1405.patch
>
>
> Brian's patch to CASSANDRA-876 suggested using a custom TProcessorFactory subclass, overriding getProcessor to reset to a default state when a new client connects. It looks like this would allow dropping CustomTThreadPoolServer as well as allowing non-thread based servers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-1405) Switch to THsHaServer, redux
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-1405:
-----------------------------------------
Assignee: Nick Bailey (was: Brandon Williams)
> Switch to THsHaServer, redux
> ----------------------------
>
> Key: CASSANDRA-1405
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1405
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Nick Bailey
> Priority: Minor
> Fix For: 0.7.0
>
>
> Brian's patch to CASSANDRA-876 suggested using a custom TProcessorFactory subclass, overriding getProcessor to reset to a default state when a new client connects. It looks like this would allow dropping CustomTThreadPoolServer as well as allowing non-thread based servers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1405) Switch to THsHaServer, redux
Posted by "Benjamin Coverston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Coverston updated CASSANDRA-1405:
------------------------------------------
Attachment: libthrift-r1026391.jar
trunk-1405.patch
New patch works with Thrift revision 1026391 (also attached)
> Switch to THsHaServer, redux
> ----------------------------
>
> Key: CASSANDRA-1405
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1405
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 0.7.1
>
> Attachments: libthrift-r1026391.jar, trunk-1405.patch
>
>
> Brian's patch to CASSANDRA-876 suggested using a custom TProcessorFactory subclass, overriding getProcessor to reset to a default state when a new client connects. It looks like this would allow dropping CustomTThreadPoolServer as well as allowing non-thread based servers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1405) Switch to THsHaServer, redux
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1405:
--------------------------------------
Fix Version/s: (was: 0.7.0)
0.7.1
Assignee: (was: Nick Bailey)
> Switch to THsHaServer, redux
> ----------------------------
>
> Key: CASSANDRA-1405
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1405
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 0.7.1
>
>
> Brian's patch to CASSANDRA-876 suggested using a custom TProcessorFactory subclass, overriding getProcessor to reset to a default state when a new client connects. It looks like this would allow dropping CustomTThreadPoolServer as well as allowing non-thread based servers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1405) Switch to THsHaServer, redux
Posted by "Benjamin Coverston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Coverston updated CASSANDRA-1405:
------------------------------------------
Attachment: trunk-1405v6.patch
This is a patch for this issue. It depends on two changes made to thrift (both committed to HEAD THRIFT-957 and THRIFT-958). This patch includes the java thrift library from changeset 959516 with the changes needed to support client identification through the use of remote socket ports.
> Switch to THsHaServer, redux
> ----------------------------
>
> Key: CASSANDRA-1405
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1405
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 0.7.1
>
> Attachments: trunk-1405v6.patch
>
>
> Brian's patch to CASSANDRA-876 suggested using a custom TProcessorFactory subclass, overriding getProcessor to reset to a default state when a new client connects. It looks like this would allow dropping CustomTThreadPoolServer as well as allowing non-thread based servers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1405) Switch to THsHaServer, redux
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915917#action_12915917 ]
Brandon Williams commented on CASSANDRA-1405:
---------------------------------------------
It looks like that is where the session consistency is being kept in a threadlocal.
> Switch to THsHaServer, redux
> ----------------------------
>
> Key: CASSANDRA-1405
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1405
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Brandon Williams
> Priority: Minor
> Fix For: 0.7.0
>
>
> Brian's patch to CASSANDRA-876 suggested using a custom TProcessorFactory subclass, overriding getProcessor to reset to a default state when a new client connects. It looks like this would allow dropping CustomTThreadPoolServer as well as allowing non-thread based servers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1405) Switch to THsHaServer, redux
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915901#action_12915901 ]
Jonathan Ellis commented on CASSANDRA-1405:
-------------------------------------------
That seems reasonable.
Why did Brian's only need SS and not CS?
> Switch to THsHaServer, redux
> ----------------------------
>
> Key: CASSANDRA-1405
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1405
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Brandon Williams
> Priority: Minor
> Fix For: 0.7.0
>
>
> Brian's patch to CASSANDRA-876 suggested using a custom TProcessorFactory subclass, overriding getProcessor to reset to a default state when a new client connects. It looks like this would allow dropping CustomTThreadPoolServer as well as allowing non-thread based servers.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.