You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/10 10:44:39 UTC

[GitHub] [incubator-shardingsphere] menghaoranss opened a new pull request #5142: Optimize MetaData Center#MetaDataCenter-phase-3-2

menghaoranss opened a new pull request #5142: Optimize MetaData Center#MetaDataCenter-phase-3-2
URL: https://github.com/apache/incubator-shardingsphere/pull/5142
 
 
   For #5128 .
   
   Changes proposed in this pull request:
   - Add metadata center tests
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #5142: Optimize MetaData Center#MetaDataCenter-phase-3-2

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #5142: Optimize MetaData Center#MetaDataCenter-phase-3-2
URL: https://github.com/apache/incubator-shardingsphere/pull/5142
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] menghaoranss commented on a change in pull request #5142: Optimize MetaData Center#MetaDataCenter-phase-3-2

Posted by GitBox <gi...@apache.org>.
menghaoranss commented on a change in pull request #5142: Optimize MetaData Center#MetaDataCenter-phase-3-2
URL: https://github.com/apache/incubator-shardingsphere/pull/5142#discussion_r406713947
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-metadatacenter/src/test/java/org/apache/shardingsphere/orchestration/core/metadatacenter/MetaDataCenterTest.java
 ##########
 @@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.orchestration.core.metadatacenter;
+
+import org.apache.shardingsphere.orchestration.center.CenterRepository;
+import org.apache.shardingsphere.orchestration.core.metadatacenter.yaml.RuleSchemaMetaDataYamlSwapper;
+import org.apache.shardingsphere.orchestration.core.metadatacenter.yaml.YamlRuleSchemaMetaData;
+import org.apache.shardingsphere.underlying.common.metadata.schema.RuleSchemaMetaData;
+import org.apache.shardingsphere.underlying.common.yaml.engine.YamlEngine;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.junit.MockitoJUnitRunner;
+
+import static org.junit.Assert.assertNotNull;
+import static org.mockito.ArgumentMatchers.anyString;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+@RunWith(MockitoJUnitRunner.class)
+public final class MetaDataCenterTest {
+    
+    @Mock
+    private CenterRepository repository;
+    
+    private MetaDataCenter metaDataCenter;
+    
+    @Before
+    public void setUp() {
+        metaDataCenter = new MetaDataCenter("test", repository);
+    }
+    
+    @Test
+    public void assertPersistMetaDataCenterNode() {
+        RuleSchemaMetaData ruleSchemaMetaData = new RuleSchemaMetaDataYamlSwapper().swap(YamlEngine.unmarshal(MetaDataTest.META_DATA, YamlRuleSchemaMetaData.class));
+        metaDataCenter.persistMetaDataCenterNode("schema", ruleSchemaMetaData);
+        verify(repository).persist(eq("/test/metadata/schema"), anyString());
+    }
+    
+    @Test
+    public void assertLoadRuleSchemaMetaData() {
+        when(repository.get("/test/metadata/schema")).thenReturn(MetaDataTest.META_DATA);
+        RuleSchemaMetaData ruleSchemaMetaData = metaDataCenter.loadRuleSchemaMetaData("schema");
+        verify(repository).get(eq("/test/metadata/schema"));
+        assertNotNull(ruleSchemaMetaData);
+        assertNotNull(ruleSchemaMetaData.getConfiguredSchemaMetaData());
+        assertNotNull(ruleSchemaMetaData.getUnconfiguredSchemaMetaDataMap());
+    }
+    
+    @Test
+    public void assertCreateMetaDataChangeListener() {
 
 Review comment:
   fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #5142: Optimize MetaData Center#MetaDataCenter-phase-3-2

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #5142: Optimize MetaData Center#MetaDataCenter-phase-3-2
URL: https://github.com/apache/incubator-shardingsphere/pull/5142#discussion_r406728920
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-metadatacenter/src/test/java/org/apache/shardingsphere/orchestration/core/metadatacenter/yaml/RuleSchemaMetaDataYamlSwapperTest.java
 ##########
 @@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.orchestration.core.metadatacenter.yaml;
+
+import org.apache.shardingsphere.orchestration.core.metadatacenter.MetaDataTest;
+import org.apache.shardingsphere.underlying.common.metadata.schema.RuleSchemaMetaData;
+import org.apache.shardingsphere.underlying.common.yaml.engine.YamlEngine;
+import org.junit.Test;
+
+import static org.junit.Assert.assertNotNull;
+
+public final class RuleSchemaMetaDataYamlSwapperTest {
+    
+    @Test
+    public void assertSwapToYamlRuleSchemaMetaData() {
+        RuleSchemaMetaData ruleSchemaMetaData = new RuleSchemaMetaDataYamlSwapper().swap(YamlEngine.unmarshal(MetaDataTest.META_DATA, YamlRuleSchemaMetaData.class));
+        YamlRuleSchemaMetaData yamlRuleSchemaMetaData = new RuleSchemaMetaDataYamlSwapper().swap(ruleSchemaMetaData);
+        assertNotNull(yamlRuleSchemaMetaData);
+        assertNotNull(yamlRuleSchemaMetaData.getConfiguredSchemaMetaData());
+    }
+    
+    @Test
+    public void assertSwapToRuleSchemaMetaData() {
+        YamlRuleSchemaMetaData yamlRuleSchemaMetaData = YamlEngine.unmarshal(MetaDataTest.META_DATA, YamlRuleSchemaMetaData.class);
+        RuleSchemaMetaData ruleSchemaMetaData = new RuleSchemaMetaDataYamlSwapper().swap(yamlRuleSchemaMetaData);
+        assertNotNull(ruleSchemaMetaData);
 
 Review comment:
   add more assert to check inner matadata.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #5142: Optimize MetaData Center#MetaDataCenter-phase-3-2

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #5142: Optimize MetaData Center#MetaDataCenter-phase-3-2
URL: https://github.com/apache/incubator-shardingsphere/pull/5142#discussion_r406707278
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-metadatacenter/src/test/java/org/apache/shardingsphere/orchestration/core/metadatacenter/MetaDataCenterTest.java
 ##########
 @@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.orchestration.core.metadatacenter;
+
+import org.apache.shardingsphere.orchestration.center.CenterRepository;
+import org.apache.shardingsphere.orchestration.core.metadatacenter.yaml.RuleSchemaMetaDataYamlSwapper;
+import org.apache.shardingsphere.orchestration.core.metadatacenter.yaml.YamlRuleSchemaMetaData;
+import org.apache.shardingsphere.underlying.common.metadata.schema.RuleSchemaMetaData;
+import org.apache.shardingsphere.underlying.common.yaml.engine.YamlEngine;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.junit.MockitoJUnitRunner;
+
+import static org.junit.Assert.assertNotNull;
+import static org.mockito.ArgumentMatchers.anyString;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+@RunWith(MockitoJUnitRunner.class)
+public final class MetaDataCenterTest {
+    
+    @Mock
+    private CenterRepository repository;
+    
+    private MetaDataCenter metaDataCenter;
+    
+    @Before
+    public void setUp() {
+        metaDataCenter = new MetaDataCenter("test", repository);
+    }
+    
+    @Test
+    public void assertPersistMetaDataCenterNode() {
+        RuleSchemaMetaData ruleSchemaMetaData = new RuleSchemaMetaDataYamlSwapper().swap(YamlEngine.unmarshal(MetaDataTest.META_DATA, YamlRuleSchemaMetaData.class));
+        metaDataCenter.persistMetaDataCenterNode("schema", ruleSchemaMetaData);
+        verify(repository).persist(eq("/test/metadata/schema"), anyString());
+    }
+    
+    @Test
+    public void assertLoadRuleSchemaMetaData() {
+        when(repository.get("/test/metadata/schema")).thenReturn(MetaDataTest.META_DATA);
+        RuleSchemaMetaData ruleSchemaMetaData = metaDataCenter.loadRuleSchemaMetaData("schema");
+        verify(repository).get(eq("/test/metadata/schema"));
+        assertNotNull(ruleSchemaMetaData);
+        assertNotNull(ruleSchemaMetaData.getConfiguredSchemaMetaData());
+        assertNotNull(ruleSchemaMetaData.getUnconfiguredSchemaMetaDataMap());
+    }
+    
+    @Test
+    public void assertCreateMetaDataChangeListener() {
 
 Review comment:
   this method is moving to other package.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5142: Optimize MetaData Center#MetaDataCenter-phase-3-2

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #5142: Optimize MetaData Center#MetaDataCenter-phase-3-2
URL: https://github.com/apache/incubator-shardingsphere/pull/5142#issuecomment-612028044
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142?src=pr&el=h1) Report
   > Merging [#5142](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/da48e1fdf99a437374a557609cc1cc2beb860d21&el=desc) will **increase** coverage by `0.27%`.
   > The diff coverage is `45.74%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5142      +/-   ##
   ============================================
   + Coverage     53.82%   54.10%   +0.27%     
   - Complexity      401      406       +5     
   ============================================
     Files          1147     1153       +6     
     Lines         20484    20520      +36     
     Branches       3696     3703       +7     
   ============================================
   + Hits          11026    11102      +76     
   + Misses         8774     8731      -43     
   - Partials        684      687       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...hestration/core/metadatacenter/MetaDataCenter.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLW1ldGFkYXRhY2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvbWV0YWRhdGFjZW50ZXIvTWV0YURhdGFDZW50ZXIuamF2YQ==) | `100.00% <ø> (+100.00%)` | `0.00 <0.00> (ø)` | |
   | [...tadatacenter/listener/MetaDataListenerManager.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLW1ldGFkYXRhY2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvbWV0YWRhdGFjZW50ZXIvbGlzdGVuZXIvTWV0YURhdGFMaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...datacenter/yaml/RuleSchemaMetaDataYamlSwapper.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLW1ldGFkYXRhY2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvbWV0YWRhdGFjZW50ZXIveWFtbC9SdWxlU2NoZW1hTWV0YURhdGFZYW1sU3dhcHBlci5qYXZh) | `97.36% <0.00%> (+97.36%)` | `0.00 <0.00> (ø)` | |
   | [...here/shardingproxy/backend/schema/LogicSchema.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3NjaGVtYS9Mb2dpY1NjaGVtYS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...rdingproxy/backend/schema/impl/ShardingSchema.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3NjaGVtYS9pbXBsL1NoYXJkaW5nU2NoZW1hLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ng/core/controller/task/SyncTaskControlStatus.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL2NvbnRyb2xsZXIvdGFzay9TeW5jVGFza0NvbnRyb2xTdGF0dXMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...aling/core/controller/task/SyncTaskController.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL2NvbnRyb2xsZXIvdGFzay9TeW5jVGFza0NvbnRyb2xsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...scaling/core/controller/task/SyncTaskProgress.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL2NvbnRyb2xsZXIvdGFzay9TeW5jVGFza1Byb2dyZXNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../execute/executor/channel/DistributionChannel.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL2V4ZWN1dGUvZXhlY3V0b3IvY2hhbm5lbC9EaXN0cmlidXRpb25DaGFubmVsLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../synctask/incremental/IncrementalDataSyncTask.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL3N5bmN0YXNrL2luY3JlbWVudGFsL0luY3JlbWVudGFsRGF0YVN5bmNUYXNrLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [21 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142?src=pr&el=footer). Last update [dca0d37...d510715](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #5142: Optimize MetaData Center#MetaDataCenter-phase-3-2

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #5142: Optimize MetaData Center#MetaDataCenter-phase-3-2
URL: https://github.com/apache/incubator-shardingsphere/pull/5142#issuecomment-612028044
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142?src=pr&el=h1) Report
   > Merging [#5142](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/da48e1fdf99a437374a557609cc1cc2beb860d21&el=desc) will **increase** coverage by `0.27%`.
   > The diff coverage is `45.74%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5142      +/-   ##
   ============================================
   + Coverage     53.82%   54.10%   +0.27%     
   - Complexity      401      406       +5     
   ============================================
     Files          1147     1153       +6     
     Lines         20484    20520      +36     
     Branches       3696     3703       +7     
   ============================================
   + Hits          11026    11102      +76     
   + Misses         8774     8731      -43     
   - Partials        684      687       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...hestration/core/metadatacenter/MetaDataCenter.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLW1ldGFkYXRhY2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvbWV0YWRhdGFjZW50ZXIvTWV0YURhdGFDZW50ZXIuamF2YQ==) | `100.00% <ø> (+100.00%)` | `0.00 <0.00> (ø)` | |
   | [...tadatacenter/listener/MetaDataListenerManager.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLW1ldGFkYXRhY2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvbWV0YWRhdGFjZW50ZXIvbGlzdGVuZXIvTWV0YURhdGFMaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...datacenter/yaml/RuleSchemaMetaDataYamlSwapper.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLW1ldGFkYXRhY2VudGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9vcmNoZXN0cmF0aW9uL2NvcmUvbWV0YWRhdGFjZW50ZXIveWFtbC9SdWxlU2NoZW1hTWV0YURhdGFZYW1sU3dhcHBlci5qYXZh) | `97.36% <0.00%> (+97.36%)` | `0.00 <0.00> (ø)` | |
   | [...here/shardingproxy/backend/schema/LogicSchema.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3NjaGVtYS9Mb2dpY1NjaGVtYS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...rdingproxy/backend/schema/impl/ShardingSchema.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3NjaGVtYS9pbXBsL1NoYXJkaW5nU2NoZW1hLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ng/core/controller/task/SyncTaskControlStatus.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL2NvbnRyb2xsZXIvdGFzay9TeW5jVGFza0NvbnRyb2xTdGF0dXMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...aling/core/controller/task/SyncTaskController.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL2NvbnRyb2xsZXIvdGFzay9TeW5jVGFza0NvbnRyb2xsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...scaling/core/controller/task/SyncTaskProgress.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL2NvbnRyb2xsZXIvdGFzay9TeW5jVGFza1Byb2dyZXNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../execute/executor/channel/DistributionChannel.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL2V4ZWN1dGUvZXhlY3V0b3IvY2hhbm5lbC9EaXN0cmlidXRpb25DaGFubmVsLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../synctask/incremental/IncrementalDataSyncTask.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL3N5bmN0YXNrL2luY3JlbWVudGFsL0luY3JlbWVudGFsRGF0YVN5bmNUYXNrLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [21 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142?src=pr&el=footer). Last update [dca0d37...3a54429](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5142?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services