You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2016/07/01 05:44:10 UTC
[jira] [Commented] (HBASE-16161) Remove a few unnecessary
(uncontended) synchronizes
[ https://issues.apache.org/jira/browse/HBASE-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15358433#comment-15358433 ]
stack commented on HBASE-16161:
-------------------------------
Remove some unnecessary synchronizes.
M hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
Remove synchronize on sendResponseIfReady, and Reader#doRunLoop.
The former is safe for many threads to call and doRunLoop has one thread
only except reading the 'adding' field.
M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
Cache hashcode. Add hash code on region scanner (and equals)
Remove synchronize on the scanner close and next call.
Remove some dup'd code between handleException and close.
> Remove a few unnecessary (uncontended) synchronizes
> ---------------------------------------------------
>
> Key: HBASE-16161
> URL: https://issues.apache.org/jira/browse/HBASE-16161
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Attachments: HBASE-16161.branch-1.001.patch
>
>
> This is followon from HBASE-15716. We have a few odd looking synchronizes. A few are probably elided after analysis concludes single thread consumer but lets remove to be clear.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)