You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/10/19 04:28:05 UTC
[GitHub] [apisix] bisakhmondal opened a new pull request #5280: docs: enabling MD045 - images with alternate text
bisakhmondal opened a new pull request #5280:
URL: https://github.com/apache/apisix/pull/5280
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
- Fix the existing instances of images without any alternate text.
- Enabled MD045 in .markdownlint.yml
closes #3586
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bisakhmondal commented on a change in pull request #5280: docs: enabling MD045 - images with alternate text
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on a change in pull request #5280:
URL: https://github.com/apache/apisix/pull/5280#discussion_r732350746
##########
File path: docs/en/latest/plugins/jwt-auth.md
##########
@@ -111,14 +114,14 @@ You can use [APISIX Dashboard](https://github.com/apache/apisix-dashboard) to co
1. Add a Consumer through the web console:
-
+
then add jwt-auth plugin in the Consumer page:
-
+
2. Create a Route or Service object and enable the jwt-auth plugin:
-
+
Review comment:
Hi! As these were just alternate texts and only going to be rendered if the URL is broken, I guess I didn't put much notice on the consistency of the texts that I was writing😅. Let me update it then. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bisakhmondal commented on a change in pull request #5280: docs: enabling MD045 - images with alternate text
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on a change in pull request #5280:
URL: https://github.com/apache/apisix/pull/5280#discussion_r731724528
##########
File path: docs/en/latest/plugins/jwt-auth.md
##########
@@ -111,14 +114,14 @@ You can use [APISIX Dashboard](https://github.com/apache/apisix-dashboard) to co
1. Add a Consumer through the web console:
-
+
then add jwt-auth plugin in the Consumer page:
-
+
-2. Create a Route or Service object and enable the jwt-auth plugin:
+1. Create a Route or Service object and enable the jwt-auth plugin:
Review comment:
ACK. Seems my vscode md lint auto-updated it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #5280: docs: enabling MD045 - images with alternate text
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #5280:
URL: https://github.com/apache/apisix/pull/5280#discussion_r732285406
##########
File path: docs/en/latest/plugins/jwt-auth.md
##########
@@ -111,14 +114,14 @@ You can use [APISIX Dashboard](https://github.com/apache/apisix-dashboard) to co
1. Add a Consumer through the web console:
-
+
then add jwt-auth plugin in the Consumer page:
-
+
2. Create a Route or Service object and enable the jwt-auth plugin:
-
+
Review comment:
May I know why we use `enabling` here, but use `enable` on Line 120?
##########
File path: docs/zh/latest/plugins/key-auth.md
##########
@@ -67,10 +67,10 @@ curl http://127.0.0.1:9080/apisix/admin/consumers -H 'X-API-KEY: edd1c9f034335f1
```
你也可以通过 web 界面来完成上面的操作，先增加一个 consumer：
-
+
Review comment:
```suggestion
```
##########
File path: docs/en/latest/aws.md
##########
@@ -208,15 +208,15 @@ Address: 44.226.102.63
Configure the IP addresses returned as your upstream nodes in your **APISIX** dashboard followed by the **Services** and **Routes** configuration. Let's say we have a `/index.php` as the URI for the first route for our first **Service** from the **Upstream** IP addresses.
-
-
-
+
+
+
## Validation
OK. Let's test the `/index.php` on `{apiSix.ApiSixServiceServiceURL}/index.php`
-
+
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bisakhmondal commented on a change in pull request #5280: docs: enabling MD045 - images with alternate text
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on a change in pull request #5280:
URL: https://github.com/apache/apisix/pull/5280#discussion_r732369754
##########
File path: docs/en/latest/plugins/jwt-auth.md
##########
@@ -111,14 +114,14 @@ You can use [APISIX Dashboard](https://github.com/apache/apisix-dashboard) to co
1. Add a Consumer through the web console:
-
+
then add jwt-auth plugin in the Consumer page:
-
+
2. Create a Route or Service object and enable the jwt-auth plugin:
-
+
Review comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5280: docs: enabling MD045 - images with alternate text
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #5280:
URL: https://github.com/apache/apisix/pull/5280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5280: docs: enabling MD045 - images with alternate text
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5280:
URL: https://github.com/apache/apisix/pull/5280#discussion_r731500179
##########
File path: docs/en/latest/plugins/jwt-auth.md
##########
@@ -111,14 +114,14 @@ You can use [APISIX Dashboard](https://github.com/apache/apisix-dashboard) to co
1. Add a Consumer through the web console:
-
+
then add jwt-auth plugin in the Consumer page:
-
+
-2. Create a Route or Service object and enable the jwt-auth plugin:
+1. Create a Route or Service object and enable the jwt-auth plugin:
Review comment:
Should be step 2?
##########
File path: docs/zh/latest/plugins/prometheus.md
##########
@@ -113,9 +113,9 @@ scrape_configs:
我们也可以在 prometheus 控制台中去检查状态:
-
+
-
+
Review comment:
Ditto
##########
File path: docs/en/latest/plugins/zipkin.md
##########
@@ -121,9 +122,9 @@ Then you can use a browser to access the webUI of Zipkin:
http://127.0.0.1:9411/zipkin
```
-
+
-
+
Review comment:
Ditto
##########
File path: docs/en/latest/plugins/prometheus.md
##########
@@ -114,9 +114,9 @@ scrape_configs:
And we can check the status at prometheus console:
-
+
-
+
Review comment:
Better to use a different name for different image
##########
File path: docs/zh/latest/plugins/zipkin.md
##########
@@ -121,9 +121,9 @@ HTTP/1.1 200 OK
http://127.0.0.1:9411/zipkin
```
-
+
-
+
Review comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org