You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Steve Carlin (Code Review)" <ge...@cloudera.org> on 2021/07/29 18:00:52 UTC
[Impala-ASF-CR] IMPALA-10832: NullPointerException in analyzing UDFs
Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17737
Change subject: IMPALA-10832: NullPointerException in analyzing UDFs
......................................................................
IMPALA-10832: NullPointerException in analyzing UDFs
Analyzing UDFs should not require the Profile thread to exist.
Change-Id: Iaba5e1c3199fb42707ea26173887929e420646dd
---
M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java
1 file changed, 7 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/17737/1
--
To view, visit http://gerrit.cloudera.org:8080/17737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaba5e1c3199fb42707ea26173887929e420646dd
Gerrit-Change-Number: 17737
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-10832: NullPointerException in analyzing UDFs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17737 )
Change subject: IMPALA-10832: NullPointerException in analyzing UDFs
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9210/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaba5e1c3199fb42707ea26173887929e420646dd
Gerrit-Change-Number: 17737
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Jul 2021 18:24:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10832: NullPointerException in analyzing UDFs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17737 )
Change subject: IMPALA-10832: NullPointerException in analyzing UDFs
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaba5e1c3199fb42707ea26173887929e420646dd
Gerrit-Change-Number: 17737
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 12:07:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10832: NullPointerException in analyzing UDFs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17737 )
Change subject: IMPALA-10832: NullPointerException in analyzing UDFs
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7376/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaba5e1c3199fb42707ea26173887929e420646dd
Gerrit-Change-Number: 17737
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 12:07:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10832: NullPointerException in analyzing UDFs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17737 )
Change subject: IMPALA-10832: NullPointerException in analyzing UDFs
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaba5e1c3199fb42707ea26173887929e420646dd
Gerrit-Change-Number: 17737
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 18:08:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10832: NullPointerException in analyzing UDFs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17737 )
Change subject: IMPALA-10832: NullPointerException in analyzing UDFs
......................................................................
IMPALA-10832: NullPointerException in analyzing UDFs
Analyzing UDFs should not require the Profile thread to exist.
Change-Id: Iaba5e1c3199fb42707ea26173887929e420646dd
Reviewed-on: http://gerrit.cloudera.org:8080/17737
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java
1 file changed, 7 insertions(+), 5 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaba5e1c3199fb42707ea26173887929e420646dd
Gerrit-Change-Number: 17737
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10832: NullPointerException in analyzing UDFs
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17737 )
Change subject: IMPALA-10832: NullPointerException in analyzing UDFs
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17737/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17737/1//COMMIT_MSG@10
PS1, Line 10:
When can this issue occur? It would be great to add a test for it if it is not too tricky.
--
To view, visit http://gerrit.cloudera.org:8080/17737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaba5e1c3199fb42707ea26173887929e420646dd
Gerrit-Change-Number: 17737
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 02 Aug 2021 09:09:59 +0000
Gerrit-HasComments: Yes