You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/07/17 01:31:29 UTC
Review Request 23589: Enable TODO and Namespace style rules
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23589/
-----------------------------------------------------------
Review request for mesos, Adam B and Niklas Nielsen.
Repository: mesos-git
Description
-------
Modified cpplint.py to support
} // namespace foo {
instead of
} // namespace foo
Also fixed all violations.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp c7c1ed4
3rdparty/libprocess/3rdparty/stout/include/stout/tuple.hpp ce77c90
3rdparty/libprocess/include/process/event.hpp 3c860f4
3rdparty/libprocess/include/process/metrics/timer.hpp 0b253aa
3rdparty/libprocess/include/process/protobuf.hpp a232107
3rdparty/libprocess/include/process/tuples/tuples.hpp ac1198e
3rdparty/libprocess/src/decoder.hpp c329882
3rdparty/libprocess/src/process.cpp 0c0fca7
include/mesos/values.hpp 1bbf2ca
src/common/date_utils.hpp 523e273
src/common/factory.hpp 94056f6
src/common/protobuf_utils.hpp 12ff00a
src/common/status_utils.hpp 1980551
src/common/type_utils.hpp ee946a3
src/common/values.cpp 15583fd
src/examples/utils.hpp e8b68f8
src/exec/exec.cpp e09ac8d
src/linux/cgroups.cpp 6a73dd7
src/linux/routing/link/link.hpp 9b0cbe9
src/linux/routing/route.hpp 435b981
src/linux/routing/route.cpp 00d41fa
src/master/constants.hpp 2daa9b0
src/master/constants.cpp e9e5e67
src/master/flags.hpp 32704ce
src/master/master.cpp 3ba8c33
src/master/repairer.cpp 151b4ed
src/python/native/mesos_executor_driver_impl.hpp ce0571f
src/python/native/mesos_executor_driver_impl.cpp 407d8d1
src/python/native/mesos_scheduler_driver_impl.hpp 772227e
src/python/native/module.hpp 1be2e38
src/python/native/module.cpp b947126
src/sched/sched.cpp c2da5bb
src/slave/flags.hpp 1fe7b7d
src/slave/gc.hpp 7b6fb83
src/slave/gc.cpp 3720255
src/slave/slave.cpp 6f0e121
support/cpplint.patch 4f1ec66
support/cpplint.py 90aa4ba
support/mesos-style.py fd12be9
Diff: https://reviews.apache.org/r/23589/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 23589: Enable TODO and Namespace style rules
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23589/#review47962
-----------------------------------------------------------
Just realized I need to split the reviews for 3rdparty, I'll update this patch and create 2 new ones too
- Timothy Chen
On July 16, 2014, 11:31 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23589/
> -----------------------------------------------------------
>
> (Updated July 16, 2014, 11:31 p.m.)
>
>
> Review request for mesos, Adam B and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Modified cpplint.py to support
> } // namespace foo {
> instead of
> } // namespace foo
>
> Also fixed all violations.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp c7c1ed4
> 3rdparty/libprocess/3rdparty/stout/include/stout/tuple.hpp ce77c90
> 3rdparty/libprocess/include/process/event.hpp 3c860f4
> 3rdparty/libprocess/include/process/metrics/timer.hpp 0b253aa
> 3rdparty/libprocess/include/process/protobuf.hpp a232107
> 3rdparty/libprocess/include/process/tuples/tuples.hpp ac1198e
> 3rdparty/libprocess/src/decoder.hpp c329882
> 3rdparty/libprocess/src/process.cpp 0c0fca7
> include/mesos/values.hpp 1bbf2ca
> src/common/date_utils.hpp 523e273
> src/common/factory.hpp 94056f6
> src/common/protobuf_utils.hpp 12ff00a
> src/common/status_utils.hpp 1980551
> src/common/type_utils.hpp ee946a3
> src/common/values.cpp 15583fd
> src/examples/utils.hpp e8b68f8
> src/exec/exec.cpp e09ac8d
> src/linux/cgroups.cpp 6a73dd7
> src/linux/routing/link/link.hpp 9b0cbe9
> src/linux/routing/route.hpp 435b981
> src/linux/routing/route.cpp 00d41fa
> src/master/constants.hpp 2daa9b0
> src/master/constants.cpp e9e5e67
> src/master/flags.hpp 32704ce
> src/master/master.cpp 3ba8c33
> src/master/repairer.cpp 151b4ed
> src/python/native/mesos_executor_driver_impl.hpp ce0571f
> src/python/native/mesos_executor_driver_impl.cpp 407d8d1
> src/python/native/mesos_scheduler_driver_impl.hpp 772227e
> src/python/native/module.hpp 1be2e38
> src/python/native/module.cpp b947126
> src/sched/sched.cpp c2da5bb
> src/slave/flags.hpp 1fe7b7d
> src/slave/gc.hpp 7b6fb83
> src/slave/gc.cpp 3720255
> src/slave/slave.cpp 6f0e121
> support/cpplint.patch 4f1ec66
> support/cpplint.py 90aa4ba
> support/mesos-style.py fd12be9
>
> Diff: https://reviews.apache.org/r/23589/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 23589: Enable TODO and Namespace style rules
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23589/#review47977
-----------------------------------------------------------
Patch looks great!
Reviews applied: [23589]
All tests passed.
- Mesos ReviewBot
On July 16, 2014, 11:31 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23589/
> -----------------------------------------------------------
>
> (Updated July 16, 2014, 11:31 p.m.)
>
>
> Review request for mesos, Adam B and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Modified cpplint.py to support
> } // namespace foo {
> instead of
> } // namespace foo
>
> Also fixed all violations.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp c7c1ed4
> 3rdparty/libprocess/3rdparty/stout/include/stout/tuple.hpp ce77c90
> 3rdparty/libprocess/include/process/event.hpp 3c860f4
> 3rdparty/libprocess/include/process/metrics/timer.hpp 0b253aa
> 3rdparty/libprocess/include/process/protobuf.hpp a232107
> 3rdparty/libprocess/include/process/tuples/tuples.hpp ac1198e
> 3rdparty/libprocess/src/decoder.hpp c329882
> 3rdparty/libprocess/src/process.cpp 0c0fca7
> include/mesos/values.hpp 1bbf2ca
> src/common/date_utils.hpp 523e273
> src/common/factory.hpp 94056f6
> src/common/protobuf_utils.hpp 12ff00a
> src/common/status_utils.hpp 1980551
> src/common/type_utils.hpp ee946a3
> src/common/values.cpp 15583fd
> src/examples/utils.hpp e8b68f8
> src/exec/exec.cpp e09ac8d
> src/linux/cgroups.cpp 6a73dd7
> src/linux/routing/link/link.hpp 9b0cbe9
> src/linux/routing/route.hpp 435b981
> src/linux/routing/route.cpp 00d41fa
> src/master/constants.hpp 2daa9b0
> src/master/constants.cpp e9e5e67
> src/master/flags.hpp 32704ce
> src/master/master.cpp 3ba8c33
> src/master/repairer.cpp 151b4ed
> src/python/native/mesos_executor_driver_impl.hpp ce0571f
> src/python/native/mesos_executor_driver_impl.cpp 407d8d1
> src/python/native/mesos_scheduler_driver_impl.hpp 772227e
> src/python/native/module.hpp 1be2e38
> src/python/native/module.cpp b947126
> src/sched/sched.cpp c2da5bb
> src/slave/flags.hpp 1fe7b7d
> src/slave/gc.hpp 7b6fb83
> src/slave/gc.cpp 3720255
> src/slave/slave.cpp 6f0e121
> support/cpplint.patch 4f1ec66
> support/cpplint.py 90aa4ba
> support/mesos-style.py fd12be9
>
> Diff: https://reviews.apache.org/r/23589/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>