[GitHub] [tvm] tqchen commented on a diff in pull request #15264: [TIR] Allow symbolic bounds in IndexMap analysis

["tqchen (via GitHub)" <gi...@apache.org>]

tqchen commented on code in PR #15264:
URL: https://github.com/apache/tvm/pull/15264#discussion_r1257339181


##########
src/arith/iter_affine_map.cc:
##########
@@ -2061,6 +2061,9 @@ class IterMapToExprNormalizer : public ExprMutator {
     if (analyzer_->CanProve(expr->extent == expr->source->extent) && is_one(expr->lower_factor)) {
       return source * expr->scale;
     } else if (analyzer_->CanProve(expr->source->extent == expr->lower_factor * expr->extent)) {
+      if (is_one(expr->extent) && !is_one(expr->lower_factor)) {

Review Comment:
   would be nice ot have a rationale here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org