You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "lahodaj (via GitHub)" <gi...@apache.org> on 2024/06/14 15:29:59 UTC
[PR] Upgrade to nb-javac from JDK 23, build 26 [netbeans]
lahodaj opened a new pull request, #7484:
URL: https://github.com/apache/netbeans/pull/7484
A draft for now, but if/when tests are OK with this version of javac, I think we should include it. (And, eventually, upgrade to a newer version when it becomes available, of course.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Upgrade to nb-javac from JDK 23, build 26 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7484:
URL: https://github.com/apache/netbeans/pull/7484#issuecomment-2214489653
this PR would have to bump the two `22` values to `23-ea` for the java hints job like we did in past a few times:
https://github.com/apache/netbeans/blob/76e1f35de7a67b9dbba66d59be6840a81fd4ae8a/.github/workflows/main.yml#L1465-L1468
this would allow us to merge https://github.com/apache/netbeans/pull/7525 right away.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Upgrade to nb-javac from JDK 23, build 30 [netbeans]
Posted by "lahodaj (via GitHub)" <gi...@apache.org>.
lahodaj commented on code in PR #7484:
URL: https://github.com/apache/netbeans/pull/7484#discussion_r1672150817
##########
.github/workflows/main.yml:
##########
@@ -1479,7 +1479,7 @@ jobs:
timeout-minutes: 60
strategy:
matrix:
- java: [ '17', '22' ]
+ java: [ '17', '22', '23-ea' ]
config: [ 'batch1', 'batch2' ]
exclude:
- java: ${{ github.event_name == 'pull_request' && 'nothing' || '22' }}
Review Comment:
Done, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Upgrade to nb-javac from JDK 23, build 26 [netbeans]
Posted by "lahodaj (via GitHub)" <gi...@apache.org>.
lahodaj commented on PR #7484:
URL: https://github.com/apache/netbeans/pull/7484#issuecomment-2212990914
The plan is to finalize with a new (currently up-to-date) javac. Ideally, sometime during this week, I think. Thanks for the comments!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Upgrade to nb-javac from JDK 23, build 26 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #7484:
URL: https://github.com/apache/netbeans/pull/7484#discussion_r1653773734
##########
nbbuild/antsrc/org/netbeans/nbbuild/extlibs/MavenCoordinate.java:
##########
@@ -83,6 +83,11 @@ public String toMavenPath() {
}
public static boolean isMavenFile(String gradleFormat) {
+ if (gradleFormat.startsWith("http://") ||
+ gradleFormat.startsWith("https://") ||
+ gradleFormat.startsWith("file://")) {
+ return false;
+ }
return gradleFormat.split(":").length > 2;
}
Review Comment:
curious: what is this for? `hash url filename` did work before this change already, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Upgrade to nb-javac from JDK 23, build 26 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7484:
URL: https://github.com/apache/netbeans/pull/7484#issuecomment-2168304547
goodbye string templates, lets hope they will be back at some point in future.
This is something we should mention on the download page since it might be surprising for users that NB 23 won't know about STs anymore even when the project is on JDK 21.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Upgrade to nb-javac from JDK 23, build 26 [netbeans]
Posted by "lahodaj (via GitHub)" <gi...@apache.org>.
lahodaj commented on PR #7484:
URL: https://github.com/apache/netbeans/pull/7484#issuecomment-2168308001
> goodbye string templates, lets hope they will be back at some point in future.
>
> This is something we should mention on the download page since it might be surprising for users that NB 23 won't know about STs anymore even when the project is on JDK 21.
Agreed. Although I don't see anything we could reasonably technically do to mitigate the situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Upgrade to nb-javac from JDK 23, build 30 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7484:
URL: https://github.com/apache/netbeans/pull/7484#issuecomment-2220749070
had to restart the platform batch2 and groovy jobs, but the failures look like normal flakiness unrelated to nb-javac. Should be green in a few minutes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Upgrade to nb-javac from JDK 23, build 30 [netbeans]
Posted by "lahodaj (via GitHub)" <gi...@apache.org>.
lahodaj commented on PR #7484:
URL: https://github.com/apache/netbeans/pull/7484#issuecomment-2220280401
The nb-javac binary download has been updated to JDK 23 build 30, as uploaded to Maven central, I think I've fixed all the comments so far. So I think this is ready for review now. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Upgrade to nb-javac from JDK 23, build 26 [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #7484:
URL: https://github.com/apache/netbeans/pull/7484#issuecomment-2211860890
@lahodaj would you mind finalizing this? While looking into the JSF modules in the NetBeans codebase I also got exceptions from the `ThisEscapeAnalyser` and I have some hopes, that they are fixed by the update of nb-javac. I would test this one, but the referenced binaries seem not to have been released and thus were not promoted to central, so the nb-javac release has to be respun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Upgrade to nb-javac from JDK 23, build 26 [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #7484:
URL: https://github.com/apache/netbeans/pull/7484#issuecomment-2212547270
Build a local test version of nb-javac and build netbeans with this applied: [build.patch.txt](https://github.com/user-attachments/files/16120508/build.patch.txt)
First impression is good, I plan to run with it the next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Upgrade to nb-javac from JDK 23, build 30 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #7484:
URL: https://github.com/apache/netbeans/pull/7484#discussion_r1672128807
##########
.github/workflows/main.yml:
##########
@@ -1479,7 +1479,7 @@ jobs:
timeout-minutes: 60
strategy:
matrix:
- java: [ '17', '22' ]
+ java: [ '17', '22', '23-ea' ]
config: [ 'batch1', 'batch2' ]
exclude:
- java: ${{ github.event_name == 'pull_request' && 'nothing' || '22' }}
Review Comment:
please _replace_ 22 with 23-ea. Also in L1458. Like:
```yml
java: [ '17', '23-ea' ]
config: [ 'batch1', 'batch2' ]
exclude:
- java: ${{ github.event_name == 'pull_request' && 'nothing' || '23-ea' }}
```
The reason for that is that the job has already a `batch1`/`batch2` axis. This would create too many nodes and NB is already above the limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Upgrade to nb-javac from JDK 23, build 30 [netbeans]
Posted by "lahodaj (via GitHub)" <gi...@apache.org>.
lahodaj commented on PR #7484:
URL: https://github.com/apache/netbeans/pull/7484#issuecomment-2220471080
Thanks! I'll merge if there's a clean test run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Upgrade to nb-javac from JDK 23, build 30 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #7484:
URL: https://github.com/apache/netbeans/pull/7484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Upgrade to nb-javac from JDK 23, build 26 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7484:
URL: https://github.com/apache/netbeans/pull/7484#issuecomment-2168536708
> Although I don't see anything we could reasonably technically do to mitigate the situation.
agreed. String templates were API+language and implemented in `java.base` and `jdk.compiler`. So even when we would create a frankenstein nb-javac and partially revert https://github.com/openjdk/jdk/pull/18688 it would create problems.
We also don't know how the next version of string templates will look like or when it will arrive - as soon it is available it would break the JDK 21 templates anyway. (preview features are locked to the JDK version for a reason)
This is the simplest approach, so +1 from me. Thanks for working on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists