You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "jonathanc-n (via GitHub)" <gi...@apache.org> on 2026/03/05 18:16:47 UTC
[PR] fix: Remove `!=0` check from `supports_collect_by_thresholds` [datafusion]
jonathanc-n opened a new pull request, #20730:
URL: https://github.com/apache/datafusion/pull/20730
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- Closes #.
## Rationale for this change
Small change to remove the TODO + != 0 check. Since the commit was made two years ago, statistics have been changed to use Precision. Exact(0) and inexact(0) are now valid stats while absent will evaluate to false
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Remove `!=0` check from `supports_collect_by_thresholds` [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #20730:
URL: https://github.com/apache/datafusion/pull/20730#discussion_r2912734055
##########
datafusion/physical-optimizer/src/join_selection.rs:
##########
@@ -87,16 +87,18 @@ fn supports_collect_by_thresholds(
threshold_byte_size: usize,
threshold_num_rows: usize,
) -> bool {
- // Currently we do not trust the 0 value from stats, due to stats collection might have bug
- // TODO check the logic in datasource::get_statistics_with_limit()
let Ok(stats) = plan.partition_statistics(None) else {
return false;
};
+ // Stats use `Precision<T>` to represent stats, where `Absent` means unknown.
+ // `Exact(0)` and `Inexact(0)` are both valid stats, and we should not treat
+ // them as unknown, `Absent` will return None (this is in regards to why
+ // `!=0` is not checked)
if let Some(byte_size) = stats.total_byte_size.get_value() {
- *byte_size != 0 && *byte_size < threshold_byte_size
Review Comment:
when would byte size ever be zero ? This seems like if the size was zero something is wrong 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Remove `!=0` check from `supports_collect_by_thresholds` [datafusion]
Posted by "jonathanc-n (via GitHub)" <gi...@apache.org>.
jonathanc-n commented on PR #20730:
URL: https://github.com/apache/datafusion/pull/20730#issuecomment-4007070410
cc @gabotechs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Remove `!=0` check from `supports_collect_by_thresholds` [datafusion]
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on code in PR #20730:
URL: https://github.com/apache/datafusion/pull/20730#discussion_r2892398034
##########
datafusion/physical-optimizer/src/join_selection.rs:
##########
@@ -87,16 +87,18 @@ fn supports_collect_by_thresholds(
threshold_byte_size: usize,
threshold_num_rows: usize,
) -> bool {
- // Currently we do not trust the 0 value from stats, due to stats collection might have bug
- // TODO check the logic in datasource::get_statistics_with_limit()
let Ok(stats) = plan.partition_statistics(None) else {
return false;
};
+ // Stats use `Precision<T>` to represent stats, where `Absent` means unknown.
+ // `Exact(0)` and `Inexact(0)` are both valid stats, and we should not treat
+ // them as unknown, `Absent` will return false (this is in regards to why
Review Comment:
```suggestion
// them as unknown, `Absent` will return None (this is in regards to why
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Remove `!=0` check from `supports_collect_by_thresholds` [datafusion]
Posted by "jonathanc-n (via GitHub)" <gi...@apache.org>.
jonathanc-n commented on code in PR #20730:
URL: https://github.com/apache/datafusion/pull/20730#discussion_r2912887419
##########
datafusion/physical-optimizer/src/join_selection.rs:
##########
@@ -87,16 +87,18 @@ fn supports_collect_by_thresholds(
threshold_byte_size: usize,
threshold_num_rows: usize,
) -> bool {
- // Currently we do not trust the 0 value from stats, due to stats collection might have bug
- // TODO check the logic in datasource::get_statistics_with_limit()
let Ok(stats) = plan.partition_statistics(None) else {
return false;
};
+ // Stats use `Precision<T>` to represent stats, where `Absent` means unknown.
+ // `Exact(0)` and `Inexact(0)` are both valid stats, and we should not treat
+ // them as unknown, `Absent` will return None (this is in regards to why
+ // `!=0` is not checked)
if let Some(byte_size) = stats.total_byte_size.get_value() {
- *byte_size != 0 && *byte_size < threshold_byte_size
Review Comment:
Byte size can be zero if working on empty table/partition or if filter exec filters down to zero rows.
This PR just removes this check as it is not longer a problem due to the addition of `Precision` (this check was added 2 years ago). This sanity check was previously here because getting statistics with limit would unwrap to zero (which would now be Absent)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Remove `!=0` check from `supports_collect_by_thresholds` [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #20730:
URL: https://github.com/apache/datafusion/pull/20730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org