You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mjsax <gi...@git.apache.org> on 2015/08/13 09:50:08 UTC

[GitHub] flink pull request: [FLINK-2306] Add support for named streams in ...

GitHub user mjsax opened a pull request:

    https://github.com/apache/flink/pull/1011

    [FLINK-2306] Add support for named streams in Storm compatibility layer

         - enabled .declareStream() and connect via stream name
         - enabled multiplt output streams
         - added .split() / .select() / strip pattern
         - added helpers in new package utils
         - adapted and extended JUnit tests
         - adapted examples


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mjsax/flink flink-2306-storm-namedStreams

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1011.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1011
    
----
commit 0b7f47fed18fbe9c9b353960b337e2d8454e11b7
Author: mjsax <mj...@informatik.hu-berlin.de>
Date:   2015-08-13T06:56:47Z

    [FLINK-2306] Add support for named streams in Storm compatibility layer
     - enabled .declareStream() and connect via stream name
     - enabled multiplt output streams
     - added .split() / .select() / strip pattern
     - added helpers in new package utils
     - adapted and extended JUnit tests
     - adapted examples
    some minor improvements (FlinkClient, integration of Tuple0)

commit c48ad0f516ee7583f8a6c4e564213fcd614c74e2
Author: mjsax <mj...@informatik.hu-berlin.de>
Date:   2015-08-12T18:56:58Z

    Added split examples
     - example for embedded Spout/Bolt
     - two test-examples for complete topologies
    Additionally:
     - updated README.md
     - extended web documentation
     - add comments to pom.xml to explain examples better

commit 71eeb4f2b77b643e0bbc0af4ed9fe212a4a306b7
Author: mjsax <mj...@informatik.hu-berlin.de>
Date:   2015-08-12T18:57:21Z

    TO BE DELETED
     - this PR depends on FLINK-2457 (Integrate Tuple0), ie, PR #983
     - this changes are hotfixes to make the branch work and are not needed after PR#983 is merged and this branch is rebased

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2306] Add support for named streams in ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1011


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2306] Add support for named streams in ...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1011#issuecomment-130692637
  
    The CU reports 3 failures.
    
    2 failures in storm-compatibility-core
    1 failure in YARN (yarn not responding)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2306] Add support for named streams in ...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1011#issuecomment-131144983
  
    Looks like an issue with shaded dependencies.
    
    Have a look here for some background on shading: https://cwiki.apache.org/confluence/display/FLINK/Hadoop+Versions+and+Dependency+Shading


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2306] Add support for named streams in ...

Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:

    https://github.com/apache/flink/pull/1011#issuecomment-131623875
  
    Fixed. This should be ready to get merged. Please review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2306] Add support for named streams in ...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1011#issuecomment-133470436
  
    Will merge this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2306] Add support for named streams in ...

Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:

    https://github.com/apache/flink/pull/1011#issuecomment-130694237
  
    Yes. It a weird compile error and it builds locally... The error is:
    `[ERROR] /home/travis/build/mjsax/flink/flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/wrappers/StormFiniteSpoutWrapper.java:[27,64] package org.apache.flink.hadoop.shaded.com.google.common.collect does not exist`
    
    I have no clue what's wrong... :/ Any suggestions?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---