[GitHub] [iceberg] jackye1995 commented on a change in pull request #3722: Spark: Use snapshot schema when reading snapshot

[GitBox <gi...@apache.org>]

jackye1995 commented on a change in pull request #3722:
URL: https://github.com/apache/iceberg/pull/3722#discussion_r769155230



##########
File path: spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/IcebergSource.java
##########
@@ -132,6 +166,14 @@ public String extractCatalog(CaseInsensitiveStringMap options) {
     return catalogAndIdentifier(options).catalog().name();
   }
 
+  private static Long propertyAsLong(CaseInsensitiveStringMap options, String property) {
+    String value = options.get(property);
+    if (value != null) {
+      return Long.parseLong(value);
+    }

Review comment:
       nit: newline after if

##########
File path: spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java
##########
@@ -120,4 +120,42 @@ public void testMetadataTables() {
         ImmutableList.of(row(ANY, ANY, null, "append", ANY, ANY)),
         sql("SELECT * FROM %s.snapshots", tableName));
   }
+
+  @Test

Review comment:
       I think we are missing a few failure test cases:
   1. Cannot specify both snapshot-id and as-of-timestamp
   2. Cannot write from table at a specific snapshot
   3. Cannot delete from table at a specific snapshot




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org