[jira] [Commented] (PARQUET-2099) [C++] Statistics::num_values() is misleading

["Matthew Topol (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422993#comment-17422993 ] 

Matthew Topol commented on PARQUET-2099:
----------------------------------------

thanks for the heads up [~emkornfield], i'll keep an eye on this so that I can update the Go implementation once a decision is reached.

> [C++] Statistics::num_values() is misleading 
> ---------------------------------------------
>
>                 Key: PARQUET-2099
>                 URL: https://issues.apache.org/jira/browse/PARQUET-2099
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-cpp
>            Reporter: Micah Kornfield
>            Priority: Major
>             Fix For: cpp-6.0.0
>
>
> num_values() in statistics seems to capture the number of encoded values.  This is misleading as everyplace else in parquet num_values() really indicates all values (null and not-null, i.e. the number of levels).  
> We should likely remove this field, rename it or at the very least update the documentation.
> CC [~zeroshade]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)