You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Henry Robinson (Code Review)" <ge...@cloudera.org> on 2017/08/21 05:23:48 UTC
[Impala-ASF-CR] IMPALA-5800: [Addendum] Fix bad import of squeasel.c
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7752
Change subject: IMPALA-5800: [Addendum] Fix bad import of squeasel.c
......................................................................
IMPALA-5800: [Addendum] Fix bad import of squeasel.c
The previous commit for IMPALA-5800 imported a slightly old version of
squeasel.c from the upstream project. In particular, the strings used to
choose the TLS version were incompatible with Impala's. This patch
corrects the error.
Change-Id: I03b76f2d3b3e2e6133e5c57a4f33ac315c889e15
---
M be/src/thirdparty/squeasel/squeasel.c
1 file changed, 9 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/7752/1
--
To view, visit http://gerrit.cloudera.org:8080/7752
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I03b76f2d3b3e2e6133e5c57a4f33ac315c889e15
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
[Impala-ASF-CR] IMPALA-5800: [Addendum] Fix bad import of squeasel.c
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5800: [Addendum] Fix bad import of squeasel.c
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1104/
--
To view, visit http://gerrit.cloudera.org:8080/7752
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03b76f2d3b3e2e6133e5c57a4f33ac315c889e15
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5800: [Addendum] Fix bad import of squeasel.c
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-5800: [Addendum] Fix bad import of squeasel.c
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7752
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03b76f2d3b3e2e6133e5c57a4f33ac315c889e15
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5800: [Addendum] Fix bad import of squeasel.c
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5800: [Addendum] Fix bad import of squeasel.c
......................................................................
IMPALA-5800: [Addendum] Fix bad import of squeasel.c
The previous commit for IMPALA-5800 imported a slightly old version of
squeasel.c from the upstream project. In particular, the strings used to
choose the TLS version were incompatible with Impala's. This patch
corrects the error.
Testing: Add tests to make sure that the expected flags are supported by
Squeasel.
Change-Id: I03b76f2d3b3e2e6133e5c57a4f33ac315c889e15
Reviewed-on: http://gerrit.cloudera.org:8080/7752
Reviewed-by: Bharath Vissapragada <bh...@cloudera.com>
Reviewed-by: Sailesh Mukil <sa...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/thirdparty/squeasel/squeasel.c
M be/src/util/webserver-test.cc
2 files changed, 33 insertions(+), 10 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Bharath Vissapragada: Looks good to me, but someone else must approve
Sailesh Mukil: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7752
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03b76f2d3b3e2e6133e5c57a4f33ac315c889e15
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-5800: [Addendum] Fix bad import of squeasel.c
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5800: [Addendum] Fix bad import of squeasel.c
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1103/
--
To view, visit http://gerrit.cloudera.org:8080/7752
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03b76f2d3b3e2e6133e5c57a4f33ac315c889e15
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5800: [Addendum] Fix bad import of squeasel.c
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5800: [Addendum] Fix bad import of squeasel.c
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7752
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03b76f2d3b3e2e6133e5c57a4f33ac315c889e15
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5800: [Addendum] Fix bad import of squeasel.c
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-5800: [Addendum] Fix bad import of squeasel.c
......................................................................
Patch Set 2: Code-Review+1
LGTM
--
To view, visit http://gerrit.cloudera.org:8080/7752
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03b76f2d3b3e2e6133e5c57a4f33ac315c889e15
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5800: [Addendum] Fix bad import of squeasel.c
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-5800: [Addendum] Fix bad import of squeasel.c
......................................................................
IMPALA-5800: [Addendum] Fix bad import of squeasel.c
The previous commit for IMPALA-5800 imported a slightly old version of
squeasel.c from the upstream project. In particular, the strings used to
choose the TLS version were incompatible with Impala's. This patch
corrects the error.
Testing: Add tests to make sure that the expected flags are supported by
Squeasel.
Change-Id: I03b76f2d3b3e2e6133e5c57a4f33ac315c889e15
---
M be/src/thirdparty/squeasel/squeasel.c
M be/src/util/webserver-test.cc
2 files changed, 33 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/7752/2
--
To view, visit http://gerrit.cloudera.org:8080/7752
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I03b76f2d3b3e2e6133e5c57a4f33ac315c889e15
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins