You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/05/28 23:51:23 UTC
Review Request 21991: Updated the slave to send terminal tasks for
terminated executors during re-registration.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21991/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Bugs: MESOS-1388
https://issues.apache.org/jira/browse/MESOS-1388
Repository: mesos-git
Description
-------
The slave must send terminal unacknowledged tasks for terminal executors so that the master can correctly reconcile tasks when the slave re-registers.
Otherwise, the master may see a missing task (terminal, unacknowledged) on the slave and incorrectly inform the framework via TASK_LOST, per MESOS-1388.
Diffs
-----
src/slave/slave.cpp 7fbedb1e4ff768d42de75d20c86a6c927f65b86b
src/tests/fault_tolerance_tests.cpp 3f2639347c7fde1b1b8e3c976e493b5fa2c3ade2
Diff: https://reviews.apache.org/r/21991/diff/
Testing
-------
Modified the existing test to ensure that MESOS-1388 is fixed.
Thanks,
Ben Mahler
Re: Review Request 21991: Updated the slave to send terminal tasks for
terminated executors during re-registration.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21991/#review44186
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On May 28, 2014, 9:51 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21991/
> -----------------------------------------------------------
>
> (Updated May 28, 2014, 9:51 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Bugs: MESOS-1388
> https://issues.apache.org/jira/browse/MESOS-1388
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The slave must send terminal unacknowledged tasks for terminal executors so that the master can correctly reconcile tasks when the slave re-registers.
>
> Otherwise, the master may see a missing task (terminal, unacknowledged) on the slave and incorrectly inform the framework via TASK_LOST, per MESOS-1388.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 7fbedb1e4ff768d42de75d20c86a6c927f65b86b
> src/tests/fault_tolerance_tests.cpp 3f2639347c7fde1b1b8e3c976e493b5fa2c3ade2
>
> Diff: https://reviews.apache.org/r/21991/diff/
>
>
> Testing
> -------
>
> Modified the existing test to ensure that MESOS-1388 is fixed.
>
>
> Thanks,
>
> Ben Mahler
>
>