[GitHub] [trafodion] DaveBirdsall commented on a change in pull request #1817: [TRAFODION-3289] Add the OVERLAY Function in the Trafodion SQL Reference Manual

[GitBox <gi...@apache.org>]

DaveBirdsall commented on a change in pull request #1817: [TRAFODION-3289] Add the OVERLAY Function in the Trafodion SQL Reference Manual
URL: https://github.com/apache/trafodion/pull/1817#discussion_r269743719
 
 

 ##########
 File path: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc
 ##########
 @@ -7072,6 +7072,191 @@ offset3
 The first three rows retrieved display null because the offset from the
 current row does not fall within the result table.
 
+<<<
+[[overlay_function]]
+== OVERLAY Function
+
+The OVERLAY function replaces some characters of the `_source-string_` (or the whole `_source-string_`) with the `_replacement-string_`.
+
+
+The OVERLAY function is similar to the INSERT function (see <<insert_function,INSERT Function>>) except that the arguments are in a different order and the `_length_` is optional.
+
+OVERLAY is a Trafodion SQL extension.
+
+`OVERLAY (_source-string_ PLACING _replacement-string_ FROM _start_ [FOR _length_])`
+
+
+[[syntax_description_of_overlay]]
+=== Syntax Description of OVERLAY
+
+* `_source-string_`
+
++
+is the string to be partly (or entirely) overlaid.
+
+* `_replacement-string_`
+
++
+is the string to overlay.
+
+* `_start_`
+
++
+is the position at which to begin the overlay.
+
++
+NOTE: The `_start_` must be an integer greater than or equal to 1.
+
++
+NOTE: If the `_start_` is greater than the length of the `_source-string_`, then the `_replacement-string_` is simply appended. 
 
 Review comment:
   Grammar. I would say, "NOTE: If `_start_` is greater ..."  (that is, omit "the" here)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services