You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/03/07 00:34:04 UTC

[GitHub] adamsaeid opened a new pull request #78: Return error if nano.db.get called with empty doc name (Fixes issue #70)

adamsaeid opened a new pull request #78: Return error if nano.db.get called with empty doc name (Fixes issue #70)
URL: https://github.com/apache/couchdb-nano/pull/78
 
 
   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   
   Return an error instead of of db info when nano.db.get is called with an empty docName. ([Issue 70](https://github.com/apache/couchdb-nano/issues/70))
   
   ## Testing recommendations
   I've created unit tests to call db.get with null, undefined and ''
   
   ## GitHub issue number
   [70](https://github.com/apache/couchdb-nano/issues/70)
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services