You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2022/12/15 18:41:22 UTC
[GitHub] [jena] afs opened a new pull request, #1675: Close Iterators
afs opened a new pull request, #1675:
URL: https://github.com/apache/jena/pull/1675
GitHub issue resolved #1670
Close iterators.
----
- [x] Commits have been squashed to remove intermediate development commit messages.
- [x] Key commit messages start with the issue number (GH-xxxx or JENA-xxxx)
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
----
See the [Apache Jena "Contributing" guide](https://github.com/apache/jena/blob/main/CONTRIBUTING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs merged pull request #1675: GH-1670: Close Iterator
Posted by GitBox <gi...@apache.org>.
afs merged PR #1675:
URL: https://github.com/apache/jena/pull/1675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on a diff in pull request #1675: GH-1670: Close Iterator
Posted by GitBox <gi...@apache.org>.
kinow commented on code in PR #1675:
URL: https://github.com/apache/jena/pull/1675#discussion_r1050066368
##########
jena-geosparql/src/main/java/org/apache/jena/geosparql/spatial/property_functions/GenericSpatialPropertyFunction.java:
##########
@@ -126,12 +127,12 @@ private boolean checkBound(ExecutionContext execCxt, Node subject) {
iter = graph.find(geometry, Geo.AS_GML_NODE, null);
}
spatialTriples.addIterator(iter);
- }
+ });
} else {
//Check for Geo predicates against the feature when no geometry literals found.
if (graph.contains(subject, SpatialExtension.GEO_LAT_NODE, null) && graph.contains(subject, SpatialExtension.GEO_LON_NODE, null)) {
- Node lat = graph.find(subject, SpatialExtension.GEO_LAT_NODE, null).next().getObject();
- Node lon = graph.find(subject, SpatialExtension.GEO_LON_NODE, null).next().getObject();
+ Node lat = G.getOneSP(graph, subject, SpatialExtension.GEO_LAT_NODE);
+ Node lon = G.getOneSP(graph, subject, SpatialExtension.GEO_LON_NODE);
Review Comment:
:ok_man:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org