[GitHub] [beam] pabloem commented on a change in pull request #14517: [BEAM-12029] Make WontImplementErrors more helpful for order-sensitive operations

[GitBox <gi...@apache.org>]

pabloem commented on a change in pull request #14517:
URL: https://github.com/apache/beam/pull/14517#discussion_r613586620



##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -1393,9 +1430,16 @@ def fill_dataframe(*args):
 
 
 
-  cummax = cummin = cumsum = cumprod = frame_base.wont_implement_method(
-      'order-sensitive')
-  diff = frame_base.wont_implement_method('order-sensitive')
+  cummax = frame_base.order_sensitive_method(pd.DataFrame, 'cummax')
+  cummin = frame_base.order_sensitive_method(pd.DataFrame, 'cummin')
+  cumprod = frame_base.order_sensitive_method(pd.DataFrame, 'cumprod')
+  cumsum = frame_base.order_sensitive_method(pd.DataFrame, 'cumsum')
+  diff = frame_base.order_sensitive_method(pd.DataFrame, 'diff')

Review comment:
       it seems that for diff, each element only depends on the previous element, not on *all previous elements*, so it may be possible to implement efficiently. Do you think it makes sense to add a bug/TODO to implement diff?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org