You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "junlinzeng-db (via GitHub)" <gi...@apache.org> on 2023/03/29 21:00:22 UTC
[GitHub] [hive] junlinzeng-db opened a new pull request, #4172: HIVE-26949: Backport HIVE-26071 to branch-3
junlinzeng-db opened a new pull request, #4172:
URL: https://github.com/apache/hive/pull/4172
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] vihangk1 merged pull request #4172: HIVE-26949: Backport HIVE-26071 to branch-3
Posted by "vihangk1 (via GitHub)" <gi...@apache.org>.
vihangk1 merged PR #4172:
URL: https://github.com/apache/hive/pull/4172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] vihangk1 commented on pull request #4172: HIVE-26949: Backport HIVE-26071 to branch-3
Posted by "vihangk1 (via GitHub)" <gi...@apache.org>.
vihangk1 commented on PR #4172:
URL: https://github.com/apache/hive/pull/4172#issuecomment-1489754101
The test failure looks unrelated. I triggered http://ci.hive.apache.org/job/hive-flaky-check/629/ to check if it is a flaky test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] vihangk1 commented on a diff in pull request #4172: HIVE-26949: Backport HIVE-26071 to branch-3
Posted by "vihangk1 (via GitHub)" <gi...@apache.org>.
vihangk1 commented on code in PR #4172:
URL: https://github.com/apache/hive/pull/4172#discussion_r1152777492
##########
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -552,6 +552,17 @@ public enum ConfVars {
"hive-metastore/_HOST@EXAMPLE.COM",
"The service principal for the metastore Thrift server. \n" +
"The special string _HOST will be replaced automatically with the correct host name."),
+ THRIFT_METASTORE_AUTHENTICATION("metastore.authentication", "hive.metastore.authentication",
+ "NONE",
+ new StringSetValidator("NONE", "JWT"),
+ "Client authentication types. Currently, only used in HTTP mode. For using kerberos use \n" +
+ "metastore.sasl.enabled \n" +
+ " NONE: no authentication check\n" +
+ " JWT: JSON Web Token authentication via JWT token. Only supported in Http/Https mode"),
+ THRIFT_METASTORE_AUTHENTICATION_JWT_JWKS_URL("metastore.authentication.jwt.jwks.url",
Review Comment:
Sorry to ask you to piggy back this on your PR, but it would be great to remove this line from this file
`//TODO (Vihang) check if this configs are needed` for the config METASTORE_CLIENT_AUTH_MODE. I forgot to remove it in my earlier PR related to this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] vihangk1 commented on a diff in pull request #4172: HIVE-26949: Backport HIVE-26071 to branch-3
Posted by "vihangk1 (via GitHub)" <gi...@apache.org>.
vihangk1 commented on code in PR #4172:
URL: https://github.com/apache/hive/pull/4172#discussion_r1154051757
##########
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -552,6 +552,17 @@ public enum ConfVars {
"hive-metastore/_HOST@EXAMPLE.COM",
"The service principal for the metastore Thrift server. \n" +
"The special string _HOST will be replaced automatically with the correct host name."),
+ THRIFT_METASTORE_AUTHENTICATION("metastore.authentication", "hive.metastore.authentication",
+ "NONE",
+ new StringSetValidator("NONE", "JWT"),
+ "Client authentication types. Currently, only used in HTTP mode. For using kerberos use \n" +
+ "metastore.sasl.enabled \n" +
+ " NONE: no authentication check\n" +
+ " JWT: JSON Web Token authentication via JWT token. Only supported in Http/Https mode"),
+ THRIFT_METASTORE_AUTHENTICATION_JWT_JWKS_URL("metastore.authentication.jwt.jwks.url",
Review Comment:
thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] vihangk1 commented on pull request #4172: HIVE-26949: Backport HIVE-26071 to branch-3
Posted by "vihangk1 (via GitHub)" <gi...@apache.org>.
vihangk1 commented on PR #4172:
URL: https://github.com/apache/hive/pull/4172#issuecomment-1489756367
I confirmed with the original PR and the backport looks good to me. +1 (pending tests)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] junlinzeng-db commented on a diff in pull request #4172: HIVE-26949: Backport HIVE-26071 to branch-3
Posted by "junlinzeng-db (via GitHub)" <gi...@apache.org>.
junlinzeng-db commented on code in PR #4172:
URL: https://github.com/apache/hive/pull/4172#discussion_r1153616798
##########
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -552,6 +552,17 @@ public enum ConfVars {
"hive-metastore/_HOST@EXAMPLE.COM",
"The service principal for the metastore Thrift server. \n" +
"The special string _HOST will be replaced automatically with the correct host name."),
+ THRIFT_METASTORE_AUTHENTICATION("metastore.authentication", "hive.metastore.authentication",
+ "NONE",
+ new StringSetValidator("NONE", "JWT"),
+ "Client authentication types. Currently, only used in HTTP mode. For using kerberos use \n" +
+ "metastore.sasl.enabled \n" +
+ " NONE: no authentication check\n" +
+ " JWT: JSON Web Token authentication via JWT token. Only supported in Http/Https mode"),
+ THRIFT_METASTORE_AUTHENTICATION_JWT_JWKS_URL("metastore.authentication.jwt.jwks.url",
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] vihangk1 commented on pull request #4172: HIVE-26949: Backport HIVE-26071 to branch-3
Posted by "vihangk1 (via GitHub)" <gi...@apache.org>.
vihangk1 commented on PR #4172:
URL: https://github.com/apache/hive/pull/4172#issuecomment-1492378959
Thanks @junlinzeng-db. Merged the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org