You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Robert Kanter <rk...@cloudera.com> on 2017/03/09 23:36:38 UTC

Re: Review Request 54705: OOZIE-1770: Create Oozie Application Master for YARN


> On Jan. 6, 2017, 7:19 a.m., Robert Kanter wrote:
> > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
> > Lines 1143-1148 (original), 991-1001 (patched)
> > <https://reviews.apache.org/r/54705/diff/2/?file=1597293#file1597293line1195>
> >
> >     Instead of doing this (which I know is equivalent to what we currently do), would it better to call ````check(...)```` instead?  I think it handles stuff better (e.g. fallback to data file, etc).  Or maybe we can extract out the common code into a new method and have them both call that, if we don't want all of ````check(...)```` here.
> 
> Peter Bacsko wrote:
>     You mean to call check() when the Launcher is already running?

Hmm, I don't remember what I was getting at here; let's ignore this for now.


> On Jan. 6, 2017, 7:19 a.m., Robert Kanter wrote:
> > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
> > Lines 1113-1117 (patched)
> > <https://reviews.apache.org/r/54705/diff/2/?file=1597293#file1597293line1328>
> >
> >     Do we need this?
> 
> Peter Bacsko wrote:
>     We might not need -Dlog4j.debug (although I think it's useful when we have logging problems) but the rest was copy-pasted from MRApps.java or already existed (your early code). The hadoop.root.logger and hadoop.root.logfile props are definitely necessary, perhaps the root loggers could be configurable.

The other stuff sounds fine then, but the ````log4j.debug=true```` turns on debug logging for Log4j itself, right?  I don't think we need that.


> On Jan. 6, 2017, 7:19 a.m., Robert Kanter wrote:
> > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
> > Lines 1115 (patched)
> > <https://reviews.apache.org/r/54705/diff/2/?file=1597293#file1597293line1330>
> >
> >     Does this mean the launcher logs can't be larger than 1GB?
> 
> Peter Bacsko wrote:
>     I don't know - this value was already here :)

It looks like this gets passed to the log4j config for the container.  It essentially sets the max filesize for when to rollover the log file.  Looking at how MRApps sets it (https://github.com/apache/hadoop/blob/f67237cbe7bc48a1b9088e990800b37529f1db2a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/util/MRApps.java#L710) to MRJobConfig.MR_AM_LOG_KB, which is 0 by default (indicating no rollover).  Given that, I'm thinking we should set this to 0 so we don't rollover - I'm not sure how well Yarn will handle a rolled over log file.


> On Jan. 6, 2017, 7:19 a.m., Robert Kanter wrote:
> > core/src/main/java/org/apache/oozie/action/hadoop/SparkActionExecutor.java
> > Lines 156-158 (patched)
> > <https://reviews.apache.org/r/54705/diff/2/?file=1597300#file1597300line160>
> >
> >     We shouldn't need the MR jars in the Spark Action :)
> 
> Peter Cseh wrote:
>     Oozie's SparkExample needs MR jars on the classpath.

That's surprising, but okay.


> On Jan. 6, 2017, 7:19 a.m., Robert Kanter wrote:
> > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java
> > Lines 1787-1821 (original), 1640-1674 (patched)
> > <https://reviews.apache.org/r/54705/diff/2/?file=1597330#file1597330line1790>
> >
> >     What's the plan here?
> 
> Peter Bacsko wrote:
>     Perhaps we don't need this test anymore.
>     
>     I'm not entirely familiar with MapReduce ACLs but I think it's related to the LauncherMapper. But we don't have a mapper anymore, but a standalone AM. Do we still care about MR ACLs?

I'm not either, but it sounds like this doesn't apply anymore so we should delete it.


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54705/#review160656
-----------------------------------------------------------


On Jan. 23, 2017, 11:43 a.m., Peter Cseh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54705/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2017, 11:43 a.m.)
> 
> 
> Review request for oozie, Purshotam Shah, Robert Kanter, and Rohini Palaniswamy.
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> Replacing the launcher MR job with a launcher AM
> 
> 
> Diffs
> -----
> 
>   client/pom.xml f99366c90887a5a45f3942291c90e1cdbfd84b3f 
>   client/src/main/java/org/apache/oozie/cli/OozieCLI.java 6e30d7eb667fe74440281fab3ca06c9f4df7bcf7 
>   client/src/main/java/org/apache/oozie/client/XOozieClient.java 8538ec7c742cc013f7c18eaff3ecf61c2835cc8a 
>   core/pom.xml 1dd104581ccab7976d788b674d2200e48a70c27f 
>   core/src/main/java/org/apache/oozie/WorkflowJobBean.java 55d79a5d5e5e4efab9eb832e9341a16bcf8959cc 
>   core/src/main/java/org/apache/oozie/action/ActionExecutor.java 1d6456b236bf9e27c0f55d9f9e3b4bd94517c797 
>   core/src/main/java/org/apache/oozie/action/hadoop/Credentials.java eadb47b07d157f45f086517ab41c4b9826f003f0 
>   core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProvider.java 6fe22fbd2fca5d873d58ece60f20d0f131371475 
>   core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProviderFactory.java PRE-CREATION 
>   core/src/main/java/org/apache/oozie/action/hadoop/DistcpActionExecutor.java 78cd257a836707c1efeac13566d6285d42970545 
>   core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 27654741101d2056b25626fbbe345183eafd612d 
>   core/src/main/java/org/apache/oozie/action/hadoop/FsELFunctions.java 801bfe6eb212b549888f0e9fb7df7b65bcf59393 
>   core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentialHelper.java 36ad1df727e869b8051481ad969771e91bc6ae07 
>   core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentials.java d7689a924059e553abaeed374eed4072933292cb 
>   core/src/main/java/org/apache/oozie/action/hadoop/HadoopELFunctions.java ad2a71d641caa71efc098ad00bfbab3cec4d9506 
>   core/src/main/java/org/apache/oozie/action/hadoop/HbaseCredentials.java 307f565786ad77f5a35b5790bd5b052b04c6eac8 
>   core/src/main/java/org/apache/oozie/action/hadoop/Hive2ActionExecutor.java 2aed936af75da38c433be5d202bdc01c2f612c76 
>   core/src/main/java/org/apache/oozie/action/hadoop/Hive2Credentials.java bd2f1f768c5b04bef4a33613baede9202144c747 
>   core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java 8e2453ef4f78f4a5f1f95b1ca2793f5d7e07ad81 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 4beeb965a461e246479c3e8ad88f92ecafca13c1 
>   core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java 9609fdc2f3440fb176b659ef16c2a23451724cf9 
>   core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 55c937249ac35e14bd63dd0c1fa962ea636afa3a 
>   core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 581d3b3219eff882f961c8e495611e873c6a5a52 
>   core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java 8b2dc16db80ad602911f1f64e60cfad41b198922 
>   core/src/main/java/org/apache/oozie/action/hadoop/ScriptLanguageActionExecutor.java f2541265ca71fb7f3b053c59775ef5e23d0d8f94 
>   core/src/main/java/org/apache/oozie/action/hadoop/ShellActionExecutor.java b9ffa7ab7ec87db8a76a3653c74974d296c8cd17 
>   core/src/main/java/org/apache/oozie/action/hadoop/SparkActionExecutor.java 8e8d7d308b294efd91e3057e0d88ee06643ab2d4 
>   core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java 6cee32aa8f5b8b36c9c7a98bb738f50b18b64624 
>   core/src/main/java/org/apache/oozie/client/rest/BulkResponseImpl.java fb021bd022d199f93fc5674843514abf45ae12a5 
>   core/src/main/java/org/apache/oozie/command/XCommand.java bdf13f65ea25e8e0f5125e2798568a2c03fffe81 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitHttpXCommand.java d2a2742ae418070a1cd0a889f14194224bc944a6 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitMRXCommand.java cc61d3de813c75c7f1cf4d405fc043253e3ca4ea 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitScriptLanguageXCommand.java 9d413059e99bc676feb63e02a2f704048eb4a355 
>   core/src/main/java/org/apache/oozie/command/wf/SubmitSqoopXCommand.java 51b739e21c802e09f4110b740138f4ff5c341fe4 
>   core/src/main/java/org/apache/oozie/coord/input/dependency/AbstractCoordInputDependency.java 0da60ec70373399414a637c22753da7e2a7e6618 
>   core/src/main/java/org/apache/oozie/dependency/hcat/EhcacheHCatDependencyCache.java 3bc467535202e13387b1d29ac678573f4154c522 
>   core/src/main/java/org/apache/oozie/service/CallableQueueService.java a86a8d0889138cd1564ca9253e5b319ea52e55cc 
>   core/src/main/java/org/apache/oozie/service/EventHandlerService.java 22c6fb0965f45c5cf2322c251d4a8aa77d263458 
>   core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 5377127736cf189bcf4aa3d62bbbeab6b3a29d52 
>   core/src/main/java/org/apache/oozie/service/Services.java 829d5f5cd90c86e6cba9854dc0b4b7df570b8900 
>   core/src/main/java/org/apache/oozie/service/ShareLibService.java b79bd37bb2b44348f220128334497d788dd922d4 
>   core/src/main/java/org/apache/oozie/servlet/CallbackServlet.java 612302173e0f485345558b0c96a8a75d2f43d238 
>   core/src/main/java/org/apache/oozie/store/OozieSchema.java 23dd1e508b6c721a10c9fe828baa5cd0d95064b4 
>   core/src/main/java/org/apache/oozie/util/ClasspathUtils.java PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/FSUtils.java PRE-CREATION 
>   core/src/main/java/org/apache/oozie/util/IOUtils.java a6c2fdae049d1df936a0345f5ffc6609ea40a5c0 
>   core/src/main/java/org/apache/oozie/util/Instrumentation.java 55e00d4dfc1009b6724918a328e254228a2f6240 
>   core/src/main/java/org/apache/oozie/util/JobUtils.java 63f88acd6fb91668baa6cd0a80b2d45435e7b213 
>   core/src/main/resources/META-INF/persistence.xml edda2d5e22856b0250a53bfde7c73fd96f85c6e9 
>   core/src/main/resources/oozie-default.xml ad103864d7631e9d3678a828bf297ca1c80f09ca 
>   core/src/main/resources/oozie-log4j.properties c86b30143f5f58135493d9e6bdba29f402a0b1fd 
>   core/src/test/java/org/apache/oozie/QueryServlet.java PRE-CREATION 
>   core/src/test/java/org/apache/oozie/action/hadoop/BlockingMapper.java PRE-CREATION 
>   core/src/test/java/org/apache/oozie/action/hadoop/CredentialForTest.java 06298916e797890731134370412f51f3456aa70c 
>   core/src/test/java/org/apache/oozie/action/hadoop/InsertTestToken.java 9da8fbe18923899489c71f40c99a01fe6522e143 
>   core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java 4baed6e42beccd2fdb55ab1e6fb150c0d8821a9c 
>   core/src/test/java/org/apache/oozie/action/hadoop/MapperReducerForTest.java 8f08ddd9fa077fc9526814fd25e7477850c51737 
>   core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java e8a140f330062c5ce8324112aae83b3d0ae1f772 
>   core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java b27ede7fae8297d982a5dee612fe714cf61f673e 
>   core/src/test/java/org/apache/oozie/action/hadoop/TestHCatCredentials.java e6d43ca820330a5f00cc5d82e8cfb88f3a814fb4 
>   core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1c4b4296682865f96857c1038e0b26c4877b6dc8 
>   core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java aa938d01b7273d6db273908e5480b71613598135 
>   core/src/test/java/org/apache/oozie/action/hadoop/TestLauncherAMCallbackNotifier.java PRE-CREATION 
>   core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 4cda6151ca5bb0d9007f11bfe712de74b1a0da26 
>   core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java 5bc7d00ff6c6c2d29806633761cba4a940ce512a 
>   core/src/test/java/org/apache/oozie/action/hadoop/TestPrepareActionsDriver.java df9e939cb236e8b65e7b3aa9ab683c33f5fa02b7 
>   core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 1531ed994740d8d509c5429f761f4aa2e83c3227 
>   core/src/test/java/org/apache/oozie/action/hadoop/TestShellMain.java e757e542cb6256906f43a36f7d30c8e8b8aa04e2 
>   core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 8ec38e498f31bb69923125e34cda5abfc8e72aa9 
>   core/src/test/java/org/apache/oozie/client/TestWorkflowXClient.java 51ae9e87d060c9e276ca74b45b24a5f5ae65e722 
>   core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 8034bbe9e6caa1672a0018daf48d649c5e5d2410 
>   core/src/test/java/org/apache/oozie/command/wf/HangServlet.java 3344cf97762c77f5660d94341e72df4243f76eb2 
>   core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 5898d1af79631a1b7e5021d9ca05685eab7225a5 
>   core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java ea90c087fc145650dfb77ac35a03ba1203ffb0f2 
>   core/src/test/java/org/apache/oozie/command/wf/TestSubmitHiveXCommand.java 43edf5efad0932aa5089ac8a6f6cfcf9f120d966 
>   core/src/test/java/org/apache/oozie/command/wf/TestSubmitMRXCommand.java 5bc5747786774766e7156cb241d5444fefe6d7cb 
>   core/src/test/java/org/apache/oozie/command/wf/TestSubmitPigXCommand.java 5a1de25c85129e0b9567d0fd045133bffc700c5d 
>   core/src/test/java/org/apache/oozie/command/wf/TestSubmitSqoopXCommand.java 49b5028bcaff62e752a9582f1ddb5fb2ec56433c 
>   core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionKillXCommand.java 72f01148ea457085f293689eda30509a1ca694d6 
>   core/src/test/java/org/apache/oozie/service/TestConfigurationService.java 42ffdbeb41e5829cdf814cf13ada331973fc33bd 
>   core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java bbca4794b693f865290adaa915d60019fc1218dd 
>   core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 8fd0c2d5080b416470a8d886f69c7e3de8fa3ffc 
>   core/src/test/java/org/apache/oozie/service/TestShareLibService.java 2d31f9a86c25c15ee50bd420fb7300ee81a20835 
>   core/src/test/java/org/apache/oozie/test/XDataTestCase.java ea778bd19f272876f1f8d38614ecba47649526ef 
>   core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1d399e4ce921af8cb2cb2e6375d425dd5f7780f7 
>   core/src/test/java/org/apache/oozie/test/XTestCase.java e1d9068f3ae0ee2ee01eb1e8f6e7164fd3c865b8 
>   core/src/test/java/org/apache/oozie/util/TestClasspathUtils.java PRE-CREATION 
>   core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java a3c7b142d08101e2bb03737871db939133bd3cd2 
>   distro/src/main/bin/addtowar.sh 399040936bde3d091d42557f6a64a0aee2b139e2 
>   docs/src/site/twiki/DG_QuickStart.twiki 2b9dc3bc753e7bf712117a92b76cdf29d11446cc 
>   docs/src/site/twiki/ENG_Building.twiki dda829b7eb9c1683f5999e436dafaa531be0920a 
>   findbugs-filter.xml PRE-CREATION 
>   hadooplibs/hadoop-auth-1/pom.xml 85e2298c25fc13bfc29ef8e0226d4eda2a95a073 
>   hadooplibs/hadoop-auth-2/pom.xml 7202b2e036bb49964435d089d9f9ff1e9237a7f7 
>   hadooplibs/hadoop-distcp-1/pom.xml bbc536b5901540e8f0835f75e185b7bb40e02e3c 
>   hadooplibs/hadoop-distcp-2/pom.xml 2c21b12068ecc9782e2d12c4376ee16bfba16af0 
>   hadooplibs/hadoop-distcp-3/pom.xml 39cf9f26c71dc5a93bceb1f750de46002d2c7f80 
>   hadooplibs/hadoop-utils-1/pom.xml a53e9bca3024d924b7e9e79f2199d30b18506132 
>   hadooplibs/hadoop-utils-1/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java c0a237777f44e4d0a9061fc468af98cec2b92aa9 
>   hadooplibs/hadoop-utils-1/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java 799dffbd7dc04654e72fa8de484143732f725fa1 
>   hadooplibs/hadoop-utils-2/pom.xml 7c4a0a10a56a79ce0513bfa2f790ffbbc5eb960a 
>   hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java a0b7d62c9432614f33baa3631660e6cb7918cd94 
>   hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java c21884c7f94dab78be4a6dea20b698476479dc17 
>   hadooplibs/hadoop-utils-3/pom.xml 2f36f8bea921ad5ff74663728b377352daf0b2ca 
>   hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java 0cf2e909283712f6e93653241f62ba601ae85706 
>   hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java c21884c7f94dab78be4a6dea20b698476479dc17 
>   hadooplibs/pom.xml 06801cc6d8dcfe1fa21367c3bb26c3f8dcaf29ec 
>   pom.xml 15f4195074c935bfaf941d2d0dc502105c4294b1 
>   release-log.txt ca9cd43260ffd3b5468631ff3c6edf2d90457e1c 
>   sharelib/distcp/pom.xml 1f3c0cc6da4e996045fcce39e0e6477df2589f63 
>   sharelib/distcp/src/main/java/org/apache/oozie/action/hadoop/DistcpMain.java 2b84f92ce0f7028e4a7f8d1b520b9dfcee6a83bd 
>   sharelib/hcatalog/pom.xml 6eb88ef85e2f8c9398df64908e7777f251c1dbfa 
>   sharelib/hive/pom.xml 13312192b634be802b3bc52726770d5c7b4057e9 
>   sharelib/hive/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java bbcaefa2b363fcf8dd7ce481fc7db71fda69bdad 
>   sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java 12e1e91cf83a109d77b6a20b022dee851447525d 
>   sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 302631182a3e70f7188272d1260c2a393b283d31 
>   sharelib/hive2/pom.xml e81bfbe0a96a490b349a2660a0b00381d56785e1 
>   sharelib/hive2/src/main/java/org/apache/oozie/action/hadoop/Hive2Main.java 54f703926e360e1942f4da41d712c29c02a3332a 
>   sharelib/hive2/src/test/java/org/apache/oozie/action/hadoop/TestHive2ActionExecutor.java 4818bb6399a6c9d315af8fee7667db3691704840 
>   sharelib/oozie/pom.xml f3ea0716a6719c44916bb50255f5f31a873fb514 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/AMRMCallBackHandler.java PRE-CREATION 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/AMRMClientAsyncFactory.java PRE-CREATION 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ActionUtils.java PRE-CREATION 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ErrorHolder.java PRE-CREATION 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/HdfsOperations.java PRE-CREATION 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/JavaMain.java 30d68e2a55dd2e6b695c27ec18e5e47a48eb9322 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java PRE-CREATION 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAMCallbackNotifier.java PRE-CREATION 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAMCallbackNotifierFactory.java PRE-CREATION 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java 785ca5ea2fdaef3b414bd96c6872035b7a10c680 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 8edebac1147d6e918c7bec921ef9ee94fb16e8e4 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LocalFsOperations.java PRE-CREATION 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/MapReduceMain.java 23447cf87427af2de8623d3715696d38c429f962 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PrepareActionsDriver.java 21ae456b768fb1cb5334a9e23e6c6082240f8dff 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PrepareActionsHandler.java PRE-CREATION 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/SequenceFileWriterFactory.java PRE-CREATION 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java f109318d949c68d4738e65de5a63de7c950a7888 
>   sharelib/oozie/src/test/java/org/apache/oozie/action/hadoop/LauncherAMTestMainClass.java PRE-CREATION 
>   sharelib/oozie/src/test/java/org/apache/oozie/action/hadoop/TestHdfsOperations.java PRE-CREATION 
>   sharelib/oozie/src/test/java/org/apache/oozie/action/hadoop/TestLauncherAM.java PRE-CREATION 
>   sharelib/pig/pom.xml 99148d73e19a42531275789e4079e11a916bbaeb 
>   sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 7de2e453e150d0cede961f9be622c4b55396d5d5 
>   sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMainWithOldAPI.java b84e2b5ee37df078e48959584eb41ec1a90200ca 
>   sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 25092ce55d8407384837b07d6d58b0218d1de7ab 
>   sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigMainWithOldAPI.java e52e6fddd474da1bd3c4b03376b7b060df2ab3b5 
>   sharelib/spark/pom.xml abef24fe7f8a95f35347c2515385f9f582864559 
>   sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkMain.java 0da74d4ac55710a541eb28ee0ac8ab36bfd4fa00 
>   sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestPyspark.java 458baaa8b6f5bc4ec5dd8395d428a7e4215fb27c 
>   sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkActionExecutor.java 8c77be0bdd7bf8cae07c4d4acd803df5730826e7 
>   sharelib/sqoop/pom.xml d5afa370b19ac3895e99c4bf594d3d32a4711d5b 
>   sharelib/sqoop/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java cb65eb82077b6ab4a08f25866386435fcb0b107c 
>   sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java 166d939b6016aa0f8a1739adc2ea17aed0b7ee7b 
>   sharelib/streaming/pom.xml 4f732724846411f13bd0204cdc2bef198b44f0c6 
>   sharelib/streaming/src/main/java/org/apache/oozie/action/hadoop/StreamingMain.java 991bf7e849171cb7847fa6d64781ceb0782dae7c 
>   sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java c7860bed2ee46d88a9ce7768b5d2c4d6cabc3094 
>   tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java 9aa4cb6bf47a632b87b187882a8e105c40f38daf 
>   webapp/pom.xml 2c4dfc263f90c2167ff76aac1297ceb19cd32ae9 
> 
> 
> Diff: https://reviews.apache.org/r/54705/diff/4/
> 
> 
> Testing
> -------
> 
> Junit tests are passing.
> Submitted jobs to a hadoop cluster successfully.
> 
> 
> Thanks,
> 
> Peter Cseh
> 
>