You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2023/06/01 01:01:13 UTC

[Impala-ASF-CR] IMPALA-11260: (Addendum) Restrict add-opens to Java 9+

Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19939 )

Change subject: IMPALA-11260: (Addendum) Restrict add-opens to Java 9+
......................................................................


Patch Set 4:

(1 comment)

Thanks for fixing this! Just have a minor comment.

http://gerrit.cloudera.org:8080/#/c/19939/4/bin/run-all-tests.sh
File bin/run-all-tests.sh:

http://gerrit.cloudera.org:8080/#/c/19939/4/bin/run-all-tests.sh@276
PS4, Line 276:     export JAVA_TOOL_OPTIONS="$JAVA11_OPTIONS ${JAVA_TOOL_OPTIONS-}"
Should we ignore these in java 8? It seems JAVA_TOOL_OPTIONS will be unusable when running tests on java 8, though I never use it for run-all-tests.sh..



-- 
To view, visit http://gerrit.cloudera.org:8080/19939
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I85953e685f6bbbd213afd93f389066e82f193ddf
Gerrit-Change-Number: 19939
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Jun 2023 01:01:13 +0000
Gerrit-HasComments: Yes