[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #24999: [FIX] Scheduler crashloopbackoff when using `hostname_callable`

[GitBox <gi...@apache.org>]

ephraimbuddy commented on code in PR #24999:
URL: https://github.com/apache/airflow/pull/24999#discussion_r921925687


##########
airflow/cli/cli_parser.py:
##########
@@ -897,6 +897,13 @@ def string_lower_type(val):
     help="The hostname of job(s) that will be checked.",
 )
 
+ARG_JOB_HOSTNAME_CALLABLE_FILTER = Arg(
+    ("--use-hostname-callable",),

Review Comment:
   What about not adding a new arg but having the hostname arg default to `get_hostname`?
   i.e
   ```python
   ARG_JOB_HOSTNAME_FILTER = Arg(
       ("--hostname",),
       default=get_hostname(),
       type=str,
       help="The hostname of job(s) that will be checked.",
   )
   ```
   The effect of this would be that the CLI check command would always check with hostname instead of none.
   
   As per the name, what do you think about `--use-configured-hostname` or `--use-default-hostname`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org